Skip to content

Commit 5f2d0ed

Browse files
committed
drm/edid: move edid load declarations to internal header
The EDID loader is internal to drm, not for drivers. Signed-off-by: Jani Nikula <[email protected]> Reviewed-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/d58a59fede286caa8766e0813f4be492a7200287.1666614699.git.jani.nikula@intel.com
1 parent 794aca0 commit 5f2d0ed

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

drivers/gpu/drm/drm_crtc_internal.h

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,3 +290,14 @@ void drm_mode_fixup_1366x768(struct drm_display_mode *mode);
290290
int drm_edid_override_show(struct drm_connector *connector, struct seq_file *m);
291291
int drm_edid_override_set(struct drm_connector *connector, const void *edid, size_t size);
292292
int drm_edid_override_reset(struct drm_connector *connector);
293+
294+
/* drm_edid_load.c */
295+
#ifdef CONFIG_DRM_LOAD_EDID_FIRMWARE
296+
const struct drm_edid *drm_edid_load_firmware(struct drm_connector *connector);
297+
#else
298+
static inline const struct drm_edid *
299+
drm_edid_load_firmware(struct drm_connector *connector)
300+
{
301+
return ERR_PTR(-ENOENT);
302+
}
303+
#endif

drivers/gpu/drm/drm_edid_load.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,13 @@
1111
#include <linux/module.h>
1212
#include <linux/platform_device.h>
1313

14-
#include <drm/drm_crtc.h>
15-
#include <drm/drm_crtc_helper.h>
14+
#include <drm/drm_connector.h>
1615
#include <drm/drm_drv.h>
1716
#include <drm/drm_edid.h>
1817
#include <drm/drm_print.h>
1918

19+
#include "drm_crtc_internal.h"
20+
2021
static char edid_firmware[PATH_MAX];
2122
module_param_string(edid_firmware, edid_firmware, sizeof(edid_firmware), 0644);
2223
MODULE_PARM_DESC(edid_firmware, "Do not probe monitor, use specified EDID blob "

include/drm/drm_edid.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -388,15 +388,8 @@ int drm_av_sync_delay(struct drm_connector *connector,
388388
const struct drm_display_mode *mode);
389389

390390
#ifdef CONFIG_DRM_LOAD_EDID_FIRMWARE
391-
const struct drm_edid *drm_edid_load_firmware(struct drm_connector *connector);
392391
int __drm_set_edid_firmware_path(const char *path);
393392
int __drm_get_edid_firmware_path(char *buf, size_t bufsize);
394-
#else
395-
static inline const struct drm_edid *
396-
drm_edid_load_firmware(struct drm_connector *connector)
397-
{
398-
return ERR_PTR(-ENOENT);
399-
}
400393
#endif
401394

402395
bool drm_edid_are_equal(const struct edid *edid1, const struct edid *edid2);

0 commit comments

Comments
 (0)