Skip to content

Commit 5f8f9bc

Browse files
Perry Yuanrafaeljw
authored andcommitted
cppc_acpi: print error message if CPPC is unsupported
The amd-pstate driver can fail when _CPC objects are not supported by the CPU. However, the current error message is ambiguous (see below) and there is no clear way for attributing the failure of the amd-pstate driver to the lack of CPPC support. [ 0.477523] amd_pstate: the _CPC object is not present in SBIOS or ACPI disabled Fix this by adding an debug message to notify the user if the amd-pstate driver failed to load due to CPPC not be supported by the CPU Reviewed-by: Mario Limonciello <[email protected]> Reviewed-by: Gautham R. Shenoy <[email protected]> Tested-by: Dhananjay Ugwekar <[email protected]> Signed-off-by: Perry Yuan <[email protected]> Acked-by: Huang Rui <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 069a2bb commit 5f8f9bc

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/acpi/cppc_acpi.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -686,8 +686,10 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)
686686

687687
if (!osc_sb_cppc2_support_acked) {
688688
pr_debug("CPPC v2 _OSC not acked\n");
689-
if (!cpc_supported_by_cpu())
689+
if (!cpc_supported_by_cpu()) {
690+
pr_debug("CPPC is not supported by the CPU\n");
690691
return -ENODEV;
692+
}
691693
}
692694

693695
/* Parse the ACPI _CPC table for this CPU. */

0 commit comments

Comments
 (0)