Skip to content

Commit 5f9e29b

Browse files
claudiubezneageertu
authored andcommitted
clk: renesas: rzg2l-cpg: Reuse code in rzg2l_cpg_reset()
Code in rzg2l_cpg_reset() is equivalent with the combined code of rzg2l_cpg_assert() and rzg2l_cpg_deassert(). There is no need to have different versions thus re-use rzg2l_cpg_assert() and rzg2l_cpg_deassert(). Signed-off-by: Claudiu Beznea <[email protected]> Reviewed-by: Geert Uytterhoeven <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Geert Uytterhoeven <[email protected]>
1 parent 5ab1619 commit 5f9e29b

File tree

1 file changed

+15
-23
lines changed

1 file changed

+15
-23
lines changed

drivers/clk/renesas/rzg2l-cpg.c

Lines changed: 15 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1410,29 +1410,6 @@ rzg2l_cpg_register_mod_clk(const struct rzg2l_mod_clk *mod,
14101410

14111411
#define rcdev_to_priv(x) container_of(x, struct rzg2l_cpg_priv, rcdev)
14121412

1413-
static int rzg2l_cpg_reset(struct reset_controller_dev *rcdev,
1414-
unsigned long id)
1415-
{
1416-
struct rzg2l_cpg_priv *priv = rcdev_to_priv(rcdev);
1417-
const struct rzg2l_cpg_info *info = priv->info;
1418-
unsigned int reg = info->resets[id].off;
1419-
u32 dis = BIT(info->resets[id].bit);
1420-
u32 we = dis << 16;
1421-
1422-
dev_dbg(rcdev->dev, "reset id:%ld offset:0x%x\n", id, CLK_RST_R(reg));
1423-
1424-
/* Reset module */
1425-
writel(we, priv->base + CLK_RST_R(reg));
1426-
1427-
/* Wait for at least one cycle of the RCLK clock (@ ca. 32 kHz) */
1428-
udelay(35);
1429-
1430-
/* Release module from reset state */
1431-
writel(we | dis, priv->base + CLK_RST_R(reg));
1432-
1433-
return 0;
1434-
}
1435-
14361413
static int rzg2l_cpg_assert(struct reset_controller_dev *rcdev,
14371414
unsigned long id)
14381415
{
@@ -1463,6 +1440,21 @@ static int rzg2l_cpg_deassert(struct reset_controller_dev *rcdev,
14631440
return 0;
14641441
}
14651442

1443+
static int rzg2l_cpg_reset(struct reset_controller_dev *rcdev,
1444+
unsigned long id)
1445+
{
1446+
int ret;
1447+
1448+
ret = rzg2l_cpg_assert(rcdev, id);
1449+
if (ret)
1450+
return ret;
1451+
1452+
/* Wait for at least one cycle of the RCLK clock (@ ca. 32 kHz) */
1453+
udelay(35);
1454+
1455+
return rzg2l_cpg_deassert(rcdev, id);
1456+
}
1457+
14661458
static int rzg2l_cpg_status(struct reset_controller_dev *rcdev,
14671459
unsigned long id)
14681460
{

0 commit comments

Comments
 (0)