Skip to content

Commit 5fe058b

Browse files
Tian Taowsakernel
authored andcommitted
i2c: qup: move to use request_irq by IRQF_NO_AUTOEN flag
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable because of requesting. Signed-off-by: Tian Tao <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent 8e98c4f commit 5fe058b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/i2c/busses/i2c-qup.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1797,12 +1797,12 @@ static int qup_i2c_probe(struct platform_device *pdev)
17971797
goto fail;
17981798

17991799
ret = devm_request_irq(qup->dev, qup->irq, qup_i2c_interrupt,
1800-
IRQF_TRIGGER_HIGH, "i2c_qup", qup);
1800+
IRQF_TRIGGER_HIGH | IRQF_NO_AUTOEN,
1801+
"i2c_qup", qup);
18011802
if (ret) {
18021803
dev_err(qup->dev, "Request %d IRQ failed\n", qup->irq);
18031804
goto fail;
18041805
}
1805-
disable_irq(qup->irq);
18061806

18071807
hw_ver = readl(qup->base + QUP_HW_VERSION);
18081808
dev_dbg(qup->dev, "Revision %x\n", hw_ver);

0 commit comments

Comments
 (0)