Skip to content

Commit 5ff422a

Browse files
andy-shevlag-linaro
authored andcommitted
leds: an30259a: Get rid of custom led_init_default_state_get()
LED core provides a helper to parse default state from firmware node. Use it instead of custom implementation. Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Lee Jones <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 156a5bb commit 5ff422a

File tree

1 file changed

+4
-17
lines changed

1 file changed

+4
-17
lines changed

drivers/leds/leds-an30259a.c

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -55,18 +55,14 @@
5555

5656
#define AN30259A_NAME "an30259a"
5757

58-
#define STATE_OFF 0
59-
#define STATE_KEEP 1
60-
#define STATE_ON 2
61-
6258
struct an30259a;
6359

6460
struct an30259a_led {
6561
struct an30259a *chip;
6662
struct fwnode_handle *fwnode;
6763
struct led_classdev cdev;
6864
u32 num;
69-
u32 default_state;
65+
enum led_default_state default_state;
7066
bool sloping;
7167
};
7268

@@ -205,7 +201,6 @@ static int an30259a_dt_init(struct i2c_client *client,
205201
struct device_node *np = dev_of_node(&client->dev), *child;
206202
int count, ret;
207203
int i = 0;
208-
const char *str;
209204
struct an30259a_led *led;
210205

211206
count = of_get_available_child_count(np);
@@ -228,15 +223,7 @@ static int an30259a_dt_init(struct i2c_client *client,
228223
led->num = source;
229224
led->chip = chip;
230225
led->fwnode = of_fwnode_handle(child);
231-
232-
if (!of_property_read_string(child, "default-state", &str)) {
233-
if (!strcmp(str, "on"))
234-
led->default_state = STATE_ON;
235-
else if (!strcmp(str, "keep"))
236-
led->default_state = STATE_KEEP;
237-
else
238-
led->default_state = STATE_OFF;
239-
}
226+
led->default_state = led_init_default_state_get(led->fwnode);
240227

241228
i++;
242229
}
@@ -261,10 +248,10 @@ static void an30259a_init_default_state(struct an30259a_led *led)
261248
int led_on, err;
262249

263250
switch (led->default_state) {
264-
case STATE_ON:
251+
case LEDS_DEFSTATE_ON:
265252
led->cdev.brightness = LED_FULL;
266253
break;
267-
case STATE_KEEP:
254+
case LEDS_DEFSTATE_KEEP:
268255
err = regmap_read(chip->regmap, AN30259A_REG_LED_ON, &led_on);
269256
if (err)
270257
break;

0 commit comments

Comments
 (0)