Skip to content

Commit 601df20

Browse files
committed
Daniel Borkmann says: ==================== pull-request: bpf 2024-07-31 We've added 2 non-merge commits during the last 2 day(s) which contain a total of 2 files changed, 2 insertions(+), 2 deletions(-). The main changes are: 1) Fix BPF selftest build after tree sync with regards to a _GNU_SOURCE macro redefined compilation error, from Stanislav Fomichev. 2) Fix a wrong test in the ASSERT_OK() check in uprobe_syscall BPF selftest, from Jiri Olsa. * tag 'for-netdev' of https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf: bpf/selftests: Fix ASSERT_OK condition check in uprobe_syscall test selftests/bpf: Filter out _GNU_SOURCE when compiling test_cpp ==================== Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
2 parents 0bf50ce + 7764b96 commit 601df20

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tools/testing/selftests/bpf/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,7 @@ $(OUTPUT)/xdp_features: xdp_features.c $(OUTPUT)/network_helpers.o $(OUTPUT)/xdp
713713
# Make sure we are able to include and link libbpf against c++.
714714
$(OUTPUT)/test_cpp: test_cpp.cpp $(OUTPUT)/test_core_extern.skel.h $(BPFOBJ)
715715
$(call msg,CXX,,$@)
716-
$(Q)$(CXX) $(CFLAGS) $(filter %.a %.o %.cpp,$^) $(LDLIBS) -o $@
716+
$(Q)$(CXX) $(subst -D_GNU_SOURCE=,,$(CFLAGS)) $(filter %.a %.o %.cpp,$^) $(LDLIBS) -o $@
717717

718718
# Benchmark runner
719719
$(OUTPUT)/bench_%.o: benchs/bench_%.c bench.h $(BPFOBJ)

tools/testing/selftests/bpf/prog_tests/uprobe_syscall.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ static void test_uretprobe_syscall_call(void)
253253
struct uprobe_syscall_executed *skel;
254254
int pid, status, err, go[2], c;
255255

256-
if (ASSERT_OK(pipe(go), "pipe"))
256+
if (!ASSERT_OK(pipe(go), "pipe"))
257257
return;
258258

259259
skel = uprobe_syscall_executed__open_and_load();

0 commit comments

Comments
 (0)