Skip to content

Commit 601e428

Browse files
author
Lee Jones
committed
mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message
In most contexts '-1' doesn't really mean much to the casual observer. In almost all cases, it's better to use a human readable define. In this case PLATFORM_DEVID_* defines have already been provided for this purpose. While we're here, let's be specific about the 'MFD devices' which failed. It will help when trying to distinguish which of the 2 sets of sub-devices we actually failed to register. Signed-off-by: Lee Jones <[email protected]> Reviewed-by: Daniel Thompson <[email protected]>
1 parent 36f1b26 commit 601e428

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/mfd/cs5535-mfd.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,11 @@ static int cs5535_mfd_probe(struct pci_dev *pdev,
127127
cs5535_mfd_cells[i].id = 0;
128128
}
129129

130-
err = mfd_add_devices(&pdev->dev, -1, cs5535_mfd_cells,
130+
err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, cs5535_mfd_cells,
131131
ARRAY_SIZE(cs5535_mfd_cells), NULL, 0, NULL);
132132
if (err) {
133-
dev_err(&pdev->dev, "MFD add devices failed: %d\n", err);
133+
dev_err(&pdev->dev,
134+
"Failed to add CS5535 sub-devices: %d\n", err);
134135
goto err_disable;
135136
}
136137

0 commit comments

Comments
 (0)