Skip to content

Commit 603fbdc

Browse files
pinchartlHans Verkuil
authored andcommitted
media: rkisp1: resizer: Use v4l2_area instead of v4l2_rect to store size
The rkisp1_rsz_config() and rkisp1_rsz_config_regs() functions use a v4l2_rect to pass frame sizes, leaving the top and left members unused and uninitialized. Use v4l2_area instead. Signed-off-by: Laurent Pinchart <[email protected]> Reviewed-by: Sakari Ailus <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
1 parent 1a6ae62 commit 603fbdc

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,8 @@ static void rkisp1_rsz_disable(struct rkisp1_resizer *rsz,
208208
static void rkisp1_rsz_config_regs(struct rkisp1_resizer *rsz,
209209
const struct v4l2_rect *sink_y,
210210
const struct v4l2_rect *sink_c,
211-
const struct v4l2_rect *src_y,
212-
const struct v4l2_rect *src_c,
211+
const struct v4l2_area *src_y,
212+
const struct v4l2_area *src_c,
213213
enum rkisp1_shadow_regs_when when)
214214
{
215215
u32 ratio, rsz_ctrl = 0;
@@ -272,7 +272,8 @@ static void rkisp1_rsz_config(struct rkisp1_resizer *rsz,
272272
const struct rkisp1_rsz_yuv_mbus_info *sink_yuv_info, *src_yuv_info;
273273
const struct v4l2_mbus_framefmt *src_fmt, *sink_fmt;
274274
const struct v4l2_rect *sink_crop;
275-
struct v4l2_rect sink_y, sink_c, src_y, src_c;
275+
struct v4l2_rect sink_y, sink_c;
276+
struct v4l2_area src_y, src_c;
276277

277278
sink_fmt = v4l2_subdev_get_pad_format(&rsz->sd, sd_state,
278279
RKISP1_RSZ_PAD_SINK);

0 commit comments

Comments
 (0)