Skip to content

Commit 6040072

Browse files
committed
rcutorture: Fix rcu_torture_fwd_cb_cr() data race
On powerpc systems, spinlock acquisition does not order prior stores against later loads. This means that this statement: rfcp->rfc_next = NULL; Can be reordered to follow this statement: WRITE_ONCE(*rfcpp, rfcp); Which is then a data race with rcu_torture_fwd_prog_cr(), specifically, this statement: rfcpn = READ_ONCE(rfcp->rfc_next) KCSAN located this data race, which represents a real failure on powerpc. Signed-off-by: Paul E. McKenney <[email protected]> Acked-by: Marco Elver <[email protected]> Cc: Andrey Konovalov <[email protected]> Cc: <[email protected]>
1 parent 43b39ca commit 6040072

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/rcu/rcutorture.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2630,7 +2630,7 @@ static void rcu_torture_fwd_cb_cr(struct rcu_head *rhp)
26302630
spin_lock_irqsave(&rfp->rcu_fwd_lock, flags);
26312631
rfcpp = rfp->rcu_fwd_cb_tail;
26322632
rfp->rcu_fwd_cb_tail = &rfcp->rfc_next;
2633-
WRITE_ONCE(*rfcpp, rfcp);
2633+
smp_store_release(rfcpp, rfcp);
26342634
WRITE_ONCE(rfp->n_launders_cb, rfp->n_launders_cb + 1);
26352635
i = ((jiffies - rfp->rcu_fwd_startat) / (HZ / FWD_CBS_HIST_DIV));
26362636
if (i >= ARRAY_SIZE(rfp->n_launders_hist))

0 commit comments

Comments
 (0)