Skip to content

Commit 60430d4

Browse files
julianbrahalinusw
authored andcommitted
pinctrl: qcom: fix unmet dependencies on GPIOLIB for GPIOLIB_IRQCHIP
When PINCTRL_QCOM_SPMI_PMIC or PINCTRL_QCOM_SSBI_PMIC is selected, and GPIOLIB is not selected, Kbuild gives the following warnings: WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP Depends on [n]: GPIOLIB [=n] Selected by [y]: - PINCTRL_QCOM_SPMI_PMIC [=y] && PINCTRL [=y] && (ARCH_QCOM [=n] || COMPILE_TEST [=y]) && OF [=y] && SPMI [=y] WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP Depends on [n]: GPIOLIB [=n] Selected by [y]: - PINCTRL_QCOM_SSBI_PMIC [=y] && PINCTRL [=y] && (ARCH_QCOM [=n] || COMPILE_TEST [=y]) && OF [=y] This is because these config options enable GPIOLIB_IRQCHIP without selecting or depending on GPIOLIB, despite GPIOLIB_IRQCHIP depending on GPIOLIB. These unmet dependency bugs were detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution. Signed-off-by: Julian Braha <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent 5592481 commit 60430d4

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/pinctrl/qcom/Kconfig

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ config PINCTRL_QCOM_SPMI_PMIC
197197
select PINMUX
198198
select PINCONF
199199
select GENERIC_PINCONF
200+
select GPIOLIB
200201
select GPIOLIB_IRQCHIP
201202
select IRQ_DOMAIN_HIERARCHY
202203
help
@@ -211,6 +212,7 @@ config PINCTRL_QCOM_SSBI_PMIC
211212
select PINMUX
212213
select PINCONF
213214
select GENERIC_PINCONF
215+
select GPIOLIB
214216
select GPIOLIB_IRQCHIP
215217
select IRQ_DOMAIN_HIERARCHY
216218
help

0 commit comments

Comments
 (0)