Skip to content

Commit 608f697

Browse files
Kan LiangPeter Zijlstra
authored andcommitted
perf/x86/intel: Support new data source for Lunar Lake
A new PEBS data source format is introduced for the p-core of Lunar Lake. The data source field is extended to 8 bits with new encodings. A new layout is introduced into the union intel_x86_pebs_dse. Introduce the lnl_latency_data() to parse the new format. Enlarge the pebs_data_source[] accordingly to include new encodings. Only the mem load and the mem store events can generate the data source. Introduce INTEL_HYBRID_LDLAT_CONSTRAINT and INTEL_HYBRID_STLAT_CONSTRAINT to mark them. Add two new bits for the new cache-related data src, L2_MHB and MSC. The L2_MHB is short for L2 Miss Handling Buffer, which is similar to LFB (Line Fill Buffer), but to track the L2 Cache misses. The MSC stands for the memory-side cache. Signed-off-by: Kan Liang <[email protected]> Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Reviewed-by: Andi Kleen <[email protected]> Reviewed-by: Ian Rogers <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent 0902624 commit 608f697

File tree

4 files changed

+113
-5
lines changed

4 files changed

+113
-5
lines changed

arch/x86/events/intel/core.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6960,6 +6960,7 @@ __init int intel_pmu_init(void)
69606960
case INTEL_ARROWLAKE:
69616961
intel_pmu_init_hybrid(hybrid_big_small);
69626962

6963+
x86_pmu.pebs_latency_data = lnl_latency_data;
69636964
x86_pmu.get_event_constraints = mtl_get_event_constraints;
69646965
x86_pmu.hw_config = adl_hw_config;
69656966

@@ -6977,6 +6978,7 @@ __init int intel_pmu_init(void)
69776978
pmu = &x86_pmu.hybrid_pmu[X86_HYBRID_PMU_ATOM_IDX];
69786979
intel_pmu_init_skt(&pmu->pmu);
69796980

6981+
intel_pmu_pebs_data_source_lnl();
69806982
pr_cont("Lunarlake Hybrid events, ");
69816983
name = "lunarlake_hybrid";
69826984
break;

arch/x86/events/intel/ds.c

Lines changed: 92 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,15 @@ union intel_x86_pebs_dse {
6363
unsigned int mtl_fwd_blk:1;
6464
unsigned int ld_reserved4:24;
6565
};
66+
struct {
67+
unsigned int lnc_dse:8;
68+
unsigned int ld_reserved5:2;
69+
unsigned int lnc_stlb_miss:1;
70+
unsigned int lnc_locked:1;
71+
unsigned int lnc_data_blk:1;
72+
unsigned int lnc_addr_blk:1;
73+
unsigned int ld_reserved6:18;
74+
};
6675
};
6776

6877

@@ -77,7 +86,7 @@ union intel_x86_pebs_dse {
7786
#define SNOOP_NONE_MISS (P(SNOOP, NONE) | P(SNOOP, MISS))
7887

7988
/* Version for Sandy Bridge and later */
80-
static u64 pebs_data_source[] = {
89+
static u64 pebs_data_source[PERF_PEBS_DATA_SOURCE_MAX] = {
8190
P(OP, LOAD) | P(LVL, MISS) | LEVEL(L3) | P(SNOOP, NA),/* 0x00:ukn L3 */
8291
OP_LH | P(LVL, L1) | LEVEL(L1) | P(SNOOP, NONE), /* 0x01: L1 local */
8392
OP_LH | P(LVL, LFB) | LEVEL(LFB) | P(SNOOP, NONE), /* 0x02: LFB hit */
@@ -173,6 +182,40 @@ void __init intel_pmu_pebs_data_source_cmt(void)
173182
__intel_pmu_pebs_data_source_cmt(pebs_data_source);
174183
}
175184

185+
/* Version for Lion Cove and later */
186+
static u64 lnc_pebs_data_source[PERF_PEBS_DATA_SOURCE_MAX] = {
187+
P(OP, LOAD) | P(LVL, MISS) | LEVEL(L3) | P(SNOOP, NA), /* 0x00: ukn L3 */
188+
OP_LH | P(LVL, L1) | LEVEL(L1) | P(SNOOP, NONE), /* 0x01: L1 hit */
189+
OP_LH | P(LVL, L1) | LEVEL(L1) | P(SNOOP, NONE), /* 0x02: L1 hit */
190+
OP_LH | P(LVL, LFB) | LEVEL(LFB) | P(SNOOP, NONE), /* 0x03: LFB/L1 Miss Handling Buffer hit */
191+
0, /* 0x04: Reserved */
192+
OP_LH | P(LVL, L2) | LEVEL(L2) | P(SNOOP, NONE), /* 0x05: L2 Hit */
193+
OP_LH | LEVEL(L2_MHB) | P(SNOOP, NONE), /* 0x06: L2 Miss Handling Buffer Hit */
194+
0, /* 0x07: Reserved */
195+
OP_LH | P(LVL, L3) | LEVEL(L3) | P(SNOOP, NONE), /* 0x08: L3 Hit */
196+
0, /* 0x09: Reserved */
197+
0, /* 0x0a: Reserved */
198+
0, /* 0x0b: Reserved */
199+
OP_LH | P(LVL, L3) | LEVEL(L3) | P(SNOOPX, FWD), /* 0x0c: L3 Hit Snoop Fwd */
200+
OP_LH | P(LVL, L3) | LEVEL(L3) | P(SNOOP, HITM), /* 0x0d: L3 Hit Snoop HitM */
201+
0, /* 0x0e: Reserved */
202+
P(OP, LOAD) | P(LVL, MISS) | P(LVL, L3) | LEVEL(L3) | P(SNOOP, HITM), /* 0x0f: L3 Miss Snoop HitM */
203+
OP_LH | LEVEL(MSC) | P(SNOOP, NONE), /* 0x10: Memory-side Cache Hit */
204+
OP_LH | P(LVL, LOC_RAM) | LEVEL(RAM) | P(SNOOP, NONE), /* 0x11: Local Memory Hit */
205+
};
206+
207+
void __init intel_pmu_pebs_data_source_lnl(void)
208+
{
209+
u64 *data_source;
210+
211+
data_source = x86_pmu.hybrid_pmu[X86_HYBRID_PMU_CORE_IDX].pebs_data_source;
212+
memcpy(data_source, lnc_pebs_data_source, sizeof(lnc_pebs_data_source));
213+
214+
data_source = x86_pmu.hybrid_pmu[X86_HYBRID_PMU_ATOM_IDX].pebs_data_source;
215+
memcpy(data_source, pebs_data_source, sizeof(pebs_data_source));
216+
__intel_pmu_pebs_data_source_cmt(data_source);
217+
}
218+
176219
static u64 precise_store_data(u64 status)
177220
{
178221
union intel_x86_pebs_dse dse;
@@ -264,7 +307,7 @@ static u64 __grt_latency_data(struct perf_event *event, u64 status,
264307

265308
WARN_ON_ONCE(hybrid_pmu(event->pmu)->pmu_type == hybrid_big);
266309

267-
dse &= PERF_PEBS_DATA_SOURCE_MASK;
310+
dse &= PERF_PEBS_DATA_SOURCE_GRT_MASK;
268311
val = hybrid_var(event->pmu, pebs_data_source)[dse];
269312

270313
pebs_set_tlb_lock(&val, tlb, lock);
@@ -300,6 +343,51 @@ u64 cmt_latency_data(struct perf_event *event, u64 status)
300343
dse.mtl_fwd_blk);
301344
}
302345

346+
static u64 lnc_latency_data(struct perf_event *event, u64 status)
347+
{
348+
union intel_x86_pebs_dse dse;
349+
union perf_mem_data_src src;
350+
u64 val;
351+
352+
dse.val = status;
353+
354+
/* LNC core latency data */
355+
val = hybrid_var(event->pmu, pebs_data_source)[status & PERF_PEBS_DATA_SOURCE_MASK];
356+
if (!val)
357+
val = P(OP, LOAD) | LEVEL(NA) | P(SNOOP, NA);
358+
359+
if (dse.lnc_stlb_miss)
360+
val |= P(TLB, MISS) | P(TLB, L2);
361+
else
362+
val |= P(TLB, HIT) | P(TLB, L1) | P(TLB, L2);
363+
364+
if (dse.lnc_locked)
365+
val |= P(LOCK, LOCKED);
366+
367+
if (dse.lnc_data_blk)
368+
val |= P(BLK, DATA);
369+
if (dse.lnc_addr_blk)
370+
val |= P(BLK, ADDR);
371+
if (!dse.lnc_data_blk && !dse.lnc_addr_blk)
372+
val |= P(BLK, NA);
373+
374+
src.val = val;
375+
if (event->hw.flags & PERF_X86_EVENT_PEBS_ST_HSW)
376+
src.mem_op = P(OP, STORE);
377+
378+
return src.val;
379+
}
380+
381+
u64 lnl_latency_data(struct perf_event *event, u64 status)
382+
{
383+
struct x86_hybrid_pmu *pmu = hybrid_pmu(event->pmu);
384+
385+
if (pmu->pmu_type == hybrid_small)
386+
return cmt_latency_data(event, status);
387+
388+
return lnc_latency_data(event, status);
389+
}
390+
303391
static u64 load_latency_data(struct perf_event *event, u64 status)
304392
{
305393
union intel_x86_pebs_dse dse;
@@ -1090,6 +1178,8 @@ struct event_constraint intel_lnc_pebs_event_constraints[] = {
10901178
INTEL_FLAGS_UEVENT_CONSTRAINT(0x100, 0x100000000ULL), /* INST_RETIRED.PREC_DIST */
10911179
INTEL_FLAGS_UEVENT_CONSTRAINT(0x0400, 0x800000000ULL),
10921180

1181+
INTEL_HYBRID_LDLAT_CONSTRAINT(0x1cd, 0x3ff),
1182+
INTEL_HYBRID_STLAT_CONSTRAINT(0x2cd, 0x3),
10931183
INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_LD(0x11d0, 0xf), /* MEM_INST_RETIRED.STLB_MISS_LOADS */
10941184
INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_ST(0x12d0, 0xf), /* MEM_INST_RETIRED.STLB_MISS_STORES */
10951185
INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_LD(0x21d0, 0xf), /* MEM_INST_RETIRED.LOCK_LOADS */

arch/x86/events/perf_event.h

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,6 +476,14 @@ struct cpu_hw_events {
476476
__EVENT_CONSTRAINT(c, n, INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS, \
477477
HWEIGHT(n), 0, PERF_X86_EVENT_PEBS_LAT_HYBRID)
478478

479+
#define INTEL_HYBRID_LDLAT_CONSTRAINT(c, n) \
480+
__EVENT_CONSTRAINT(c, n, INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS, \
481+
HWEIGHT(n), 0, PERF_X86_EVENT_PEBS_LAT_HYBRID|PERF_X86_EVENT_PEBS_LD_HSW)
482+
483+
#define INTEL_HYBRID_STLAT_CONSTRAINT(c, n) \
484+
__EVENT_CONSTRAINT(c, n, INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS, \
485+
HWEIGHT(n), 0, PERF_X86_EVENT_PEBS_LAT_HYBRID|PERF_X86_EVENT_PEBS_ST_HSW)
486+
479487
/* Event constraint, but match on all event flags too. */
480488
#define INTEL_FLAGS_EVENT_CONSTRAINT(c, n) \
481489
EVENT_CONSTRAINT(c, n, ARCH_PERFMON_EVENTSEL_EVENT|X86_ALL_EVENT_FLAGS)
@@ -655,8 +663,10 @@ enum {
655663
x86_lbr_exclusive_max,
656664
};
657665

658-
#define PERF_PEBS_DATA_SOURCE_MAX 0x10
666+
#define PERF_PEBS_DATA_SOURCE_MAX 0x100
659667
#define PERF_PEBS_DATA_SOURCE_MASK (PERF_PEBS_DATA_SOURCE_MAX - 1)
668+
#define PERF_PEBS_DATA_SOURCE_GRT_MAX 0x10
669+
#define PERF_PEBS_DATA_SOURCE_GRT_MASK (PERF_PEBS_DATA_SOURCE_GRT_MAX - 1)
660670

661671
enum hybrid_cpu_type {
662672
HYBRID_INTEL_NONE,
@@ -1552,6 +1562,8 @@ u64 grt_latency_data(struct perf_event *event, u64 status);
15521562

15531563
u64 cmt_latency_data(struct perf_event *event, u64 status);
15541564

1565+
u64 lnl_latency_data(struct perf_event *event, u64 status);
1566+
15551567
extern struct event_constraint intel_core2_pebs_event_constraints[];
15561568

15571569
extern struct event_constraint intel_atom_pebs_event_constraints[];
@@ -1673,6 +1685,8 @@ void intel_pmu_pebs_data_source_mtl(void);
16731685

16741686
void intel_pmu_pebs_data_source_cmt(void);
16751687

1688+
void intel_pmu_pebs_data_source_lnl(void);
1689+
16761690
int intel_pmu_setup_lbr_filter(struct perf_event *event);
16771691

16781692
void intel_pt_interrupt(void);

include/uapi/linux/perf_event.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1349,12 +1349,14 @@ union perf_mem_data_src {
13491349
#define PERF_MEM_LVLNUM_L2 0x02 /* L2 */
13501350
#define PERF_MEM_LVLNUM_L3 0x03 /* L3 */
13511351
#define PERF_MEM_LVLNUM_L4 0x04 /* L4 */
1352-
/* 5-0x7 available */
1352+
#define PERF_MEM_LVLNUM_L2_MHB 0x05 /* L2 Miss Handling Buffer */
1353+
#define PERF_MEM_LVLNUM_MSC 0x06 /* Memory-side Cache */
1354+
/* 0x7 available */
13531355
#define PERF_MEM_LVLNUM_UNC 0x08 /* Uncached */
13541356
#define PERF_MEM_LVLNUM_CXL 0x09 /* CXL */
13551357
#define PERF_MEM_LVLNUM_IO 0x0a /* I/O */
13561358
#define PERF_MEM_LVLNUM_ANY_CACHE 0x0b /* Any cache */
1357-
#define PERF_MEM_LVLNUM_LFB 0x0c /* LFB */
1359+
#define PERF_MEM_LVLNUM_LFB 0x0c /* LFB / L1 Miss Handling Buffer */
13581360
#define PERF_MEM_LVLNUM_RAM 0x0d /* RAM */
13591361
#define PERF_MEM_LVLNUM_PMEM 0x0e /* PMEM */
13601362
#define PERF_MEM_LVLNUM_NA 0x0f /* N/A */

0 commit comments

Comments
 (0)