scsi: bnx2fc: fix boolreturn.cocci warnings

intel-lab-lkp · martinkpetersen · commit 60f537d57552 · 2020-03-31T22:35:02.000-04:00
drivers/scsi/bnx2fc/bnx2fc_hwi.c:1019:9-10: WARNING: return of 0/1 in function 'bnx2fc_pending_work' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: 7733111 ("scsi: bnx2fc: Process the RQE with CQE in interrupt context") CC: Javed Hasan <jhasan@marvell.com> Acked-by: Javed Hasan <jhasan@marvell.com> Signed-off-by: kbuild test robot <lkp@intel.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
@@ -1016,7 +1016,7 @@ static bool bnx2fc_pending_work(struct bnx2fc_rport *tgt, unsigned int wqe)
 	xid = wqe & FCOE_PEND_WQ_CQE_TASK_ID;
 	if (xid >= hba->max_tasks) {
 		pr_err(PFX "ERROR:xid out of range\n");
-		return 0;
+		return false;
 	}
 
 	task_idx = xid / BNX2FC_TASKS_PER_PAGE;
@@ -1059,14 +1059,14 @@ static bool bnx2fc_pending_work(struct bnx2fc_rport *tgt, unsigned int wqe)
 			list_add_tail(&work->list, &fps->work_list);
 			wake_up_process(fps->iothread);
 			spin_unlock_bh(&fps->fp_work_lock);
-			return 1;
+			return true;
 		}
 	}
 	spin_unlock_bh(&fps->fp_work_lock);
 	bnx2fc_process_cq_compl(tgt, wqe,
 				rq_data_buff, num_rq, task);
 
-	return 1;
+	return true;
 }
 
 int bnx2fc_process_new_cqes(struct bnx2fc_rport *tgt)

Original file line number	Diff line number	Diff line change
`@@ -1016,7 +1016,7 @@ static bool bnx2fc_pending_work(struct bnx2fc_rport *tgt, unsigned int wqe)`
`1016`	`1016`	`xid = wqe & FCOE_PEND_WQ_CQE_TASK_ID;`
`1017`	`1017`	`if (xid >= hba->max_tasks) {`
`1018`	`1018`	`pr_err(PFX "ERROR:xid out of range\n");`
`1019`		`- return 0;`
	`1019`	`+ return false;`
`1020`	`1020`	`}`
`1021`	`1021`
`1022`	`1022`	`task_idx = xid / BNX2FC_TASKS_PER_PAGE;`
`@@ -1059,14 +1059,14 @@ static bool bnx2fc_pending_work(struct bnx2fc_rport *tgt, unsigned int wqe)`
`1059`	`1059`	`list_add_tail(&work->list, &fps->work_list);`
`1060`	`1060`	`wake_up_process(fps->iothread);`
`1061`	`1061`	`spin_unlock_bh(&fps->fp_work_lock);`
`1062`		`- return 1;`
	`1062`	`+ return true;`
`1063`	`1063`	`}`
`1064`	`1064`	`}`
`1065`	`1065`	`spin_unlock_bh(&fps->fp_work_lock);`
`1066`	`1066`	`bnx2fc_process_cq_compl(tgt, wqe,`
`1067`	`1067`	`rq_data_buff, num_rq, task);`
`1068`	`1068`
`1069`		`- return 1;`
	`1069`	`+ return true;`
`1070`	`1070`	`}`
`1071`	`1071`
`1072`	`1072`	`int bnx2fc_process_new_cqes(struct bnx2fc_rport *tgt)`