Skip to content

Commit 610cd4e

Browse files
committed
Merge branch 'x86-uv-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull x86 UV updates from Ingo Molnar: "Three UV related cleanups" * 'x86-uv-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: x86/platform/UV: Use efi_enabled() instead of test_bit() x86/platform/UV: Remove uv_bios_call_reentrant() x86/platform/UV: Remove unnecessary #ifdef CONFIG_EFI
2 parents 60970c1 + 8945d96 commit 610cd4e

File tree

2 files changed

+1
-20
lines changed

2 files changed

+1
-20
lines changed

arch/x86/include/asm/uv/bios.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@ enum uv_memprotect {
141141
*/
142142
extern s64 uv_bios_call(enum uv_bios_cmd, u64, u64, u64, u64, u64);
143143
extern s64 uv_bios_call_irqsave(enum uv_bios_cmd, u64, u64, u64, u64, u64);
144-
extern s64 uv_bios_call_reentrant(enum uv_bios_cmd, u64, u64, u64, u64, u64);
145144

146145
extern s64 uv_bios_get_sn_info(int, int *, long *, long *, long *, long *);
147146
extern s64 uv_bios_freq_base(u64, u64 *);
@@ -152,11 +151,7 @@ extern s64 uv_bios_change_memprotect(u64, u64, enum uv_memprotect);
152151
extern s64 uv_bios_reserved_page_pa(u64, u64 *, u64 *, u64 *);
153152
extern int uv_bios_set_legacy_vga_target(bool decode, int domain, int bus);
154153

155-
#ifdef CONFIG_EFI
156154
extern void uv_bios_init(void);
157-
#else
158-
void uv_bios_init(void) { }
159-
#endif
160155

161156
extern unsigned long sn_rtc_cycles_per_second;
162157
extern int uv_type;

arch/x86/platform/uv/bios_uv.c

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ static s64 __uv_bios_call(enum uv_bios_cmd which, u64 a1, u64 a2, u64 a3,
4545
* If EFI_OLD_MEMMAP is set, we need to fall back to using our old EFI
4646
* callback method, which uses efi_call() directly, with the kernel page tables:
4747
*/
48-
if (unlikely(test_bit(EFI_OLD_MEMMAP, &efi.flags)))
48+
if (unlikely(efi_enabled(EFI_OLD_MEMMAP)))
4949
ret = efi_call((void *)__va(tab->function), (u64)which, a1, a2, a3, a4, a5);
5050
else
5151
ret = efi_call_virt_pointer(tab, function, (u64)which, a1, a2, a3, a4, a5);
@@ -85,18 +85,6 @@ s64 uv_bios_call_irqsave(enum uv_bios_cmd which, u64 a1, u64 a2, u64 a3,
8585
return ret;
8686
}
8787

88-
s64 uv_bios_call_reentrant(enum uv_bios_cmd which, u64 a1, u64 a2, u64 a3,
89-
u64 a4, u64 a5)
90-
{
91-
s64 ret;
92-
93-
preempt_disable();
94-
ret = uv_bios_call(which, a1, a2, a3, a4, a5);
95-
preempt_enable();
96-
97-
return ret;
98-
}
99-
10088

10189
long sn_partition_id;
10290
EXPORT_SYMBOL_GPL(sn_partition_id);
@@ -207,7 +195,6 @@ int uv_bios_set_legacy_vga_target(bool decode, int domain, int bus)
207195
}
208196
EXPORT_SYMBOL_GPL(uv_bios_set_legacy_vga_target);
209197

210-
#ifdef CONFIG_EFI
211198
void uv_bios_init(void)
212199
{
213200
uv_systab = NULL;
@@ -237,4 +224,3 @@ void uv_bios_init(void)
237224
}
238225
pr_info("UV: UVsystab: Revision:%x\n", uv_systab->revision);
239226
}
240-
#endif

0 commit comments

Comments
 (0)