Skip to content

Commit 61ddf5f

Browse files
tobluxchleroy
authored andcommitted
bus: fsl-mc: Use strscpy() instead of strscpy_pad()
Both destination buffers are already zero-initialized, making strscpy() sufficient for safely copying 'obj_type'. The additional NUL-padding performed by strscpy_pad() is unnecessary. If the destination buffer has a fixed length, strscpy() automatically determines its size using sizeof() when the argument is omitted. This makes the explicit size arguments unnecessary. No functional changes intended. Signed-off-by: Thorsten Blum <[email protected]> Reviewed-by: Ioana Ciornei <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Christophe Leroy <[email protected]>
1 parent 5ddac92 commit 61ddf5f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/bus/fsl-mc/dprc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ int dprc_set_obj_irq(struct fsl_mc_io *mc_io,
489489
cmd_params->irq_addr = cpu_to_le64(irq_cfg->paddr);
490490
cmd_params->irq_num = cpu_to_le32(irq_cfg->irq_num);
491491
cmd_params->obj_id = cpu_to_le32(obj_id);
492-
strscpy_pad(cmd_params->obj_type, obj_type, 16);
492+
strscpy(cmd_params->obj_type, obj_type);
493493

494494
/* send command to mc*/
495495
return mc_send_command(mc_io, &cmd);
@@ -561,7 +561,7 @@ int dprc_get_obj_region(struct fsl_mc_io *mc_io,
561561
cmd_params = (struct dprc_cmd_get_obj_region *)cmd.params;
562562
cmd_params->obj_id = cpu_to_le32(obj_id);
563563
cmd_params->region_index = region_index;
564-
strscpy_pad(cmd_params->obj_type, obj_type, 16);
564+
strscpy(cmd_params->obj_type, obj_type);
565565

566566
/* send command to mc*/
567567
err = mc_send_command(mc_io, &cmd);

0 commit comments

Comments
 (0)