Skip to content

Commit 62e027f

Browse files
rarun-mchpkuba-moo
authored andcommitted
net: dsa: microchip: remove IRQF_TRIGGER_FALLING in request_threaded_irq
KSZ swithes used interrupts for detecting the phy link up and down. During registering the interrupt handler, it used IRQF_TRIGGER_FALLING flag. But this flag has to be retrieved from device tree instead of hard coding in the driver, so removing the flag. Fixes: ff319a6 ("net: dsa: microchip: move interrupt handling logic from lan937x to ksz_common") Reported-by: Christian Eggers <[email protected]> Signed-off-by: Arun Ramadoss <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 2856a62 commit 62e027f

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/net/dsa/microchip/ksz_common.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1996,8 +1996,7 @@ static int ksz_irq_common_setup(struct ksz_device *dev, struct ksz_irq *kirq)
19961996
irq_create_mapping(kirq->domain, n);
19971997

19981998
ret = request_threaded_irq(kirq->irq_num, NULL, ksz_irq_thread_fn,
1999-
IRQF_ONESHOT | IRQF_TRIGGER_FALLING,
2000-
kirq->name, kirq);
1999+
IRQF_ONESHOT, kirq->name, kirq);
20012000
if (ret)
20022001
goto out;
20032002

0 commit comments

Comments
 (0)