Skip to content

Commit 63379db

Browse files
committed
drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_tail()
drm_atomic_helper_commit_tail() is the final part of an atomic commit, and is given a parameter with the drm_atomic_state being committed. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Reviewed-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Maxime Ripard <[email protected]>
1 parent c0a9882 commit 63379db

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

drivers/gpu/drm/drm_atomic_helper.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1768,7 +1768,7 @@ EXPORT_SYMBOL(drm_atomic_helper_wait_for_flip_done);
17681768

17691769
/**
17701770
* drm_atomic_helper_commit_tail - commit atomic update to hardware
1771-
* @old_state: atomic state object with old state structures
1771+
* @state: atomic state object being committed
17721772
*
17731773
* This is the default implementation for the
17741774
* &drm_mode_config_helper_funcs.atomic_commit_tail hook, for drivers
@@ -1779,23 +1779,23 @@ EXPORT_SYMBOL(drm_atomic_helper_wait_for_flip_done);
17791779
* Note that the default ordering of how the various stages are called is to
17801780
* match the legacy modeset helper library closest.
17811781
*/
1782-
void drm_atomic_helper_commit_tail(struct drm_atomic_state *old_state)
1782+
void drm_atomic_helper_commit_tail(struct drm_atomic_state *state)
17831783
{
1784-
struct drm_device *dev = old_state->dev;
1784+
struct drm_device *dev = state->dev;
17851785

1786-
drm_atomic_helper_commit_modeset_disables(dev, old_state);
1786+
drm_atomic_helper_commit_modeset_disables(dev, state);
17871787

1788-
drm_atomic_helper_commit_planes(dev, old_state, 0);
1788+
drm_atomic_helper_commit_planes(dev, state, 0);
17891789

1790-
drm_atomic_helper_commit_modeset_enables(dev, old_state);
1790+
drm_atomic_helper_commit_modeset_enables(dev, state);
17911791

1792-
drm_atomic_helper_fake_vblank(old_state);
1792+
drm_atomic_helper_fake_vblank(state);
17931793

1794-
drm_atomic_helper_commit_hw_done(old_state);
1794+
drm_atomic_helper_commit_hw_done(state);
17951795

1796-
drm_atomic_helper_wait_for_vblanks(dev, old_state);
1796+
drm_atomic_helper_wait_for_vblanks(dev, state);
17971797

1798-
drm_atomic_helper_cleanup_planes(dev, old_state);
1798+
drm_atomic_helper_cleanup_planes(dev, state);
17991799
}
18001800
EXPORT_SYMBOL(drm_atomic_helper_commit_tail);
18011801

0 commit comments

Comments
 (0)