Skip to content

Commit 634b06d

Browse files
fenghusthucminyard
authored andcommitted
ipmi/watchdog: add missing newlines when printing parameters by sysfs
When I cat some ipmi_watchdog parameters by sysfs, it displays as follows. It's better to add a newline for easy reading. root@(none):/# cat /sys/module/ipmi_watchdog/parameters/action resetroot@(none):/# cat /sys/module/ipmi_watchdog/parameters/preaction pre_noneroot@(none):/# cat /sys/module/ipmi_watchdog/parameters/preop preop_noneroot@(none):/# Signed-off-by: Xiongfeng Wang <[email protected]> Message-Id: <[email protected]> Signed-off-by: Corey Minyard <[email protected]>
1 parent a7f0f92 commit 634b06d

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

drivers/char/ipmi/ipmi_watchdog.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,12 +232,17 @@ static int set_param_str(const char *val, const struct kernel_param *kp)
232232
static int get_param_str(char *buffer, const struct kernel_param *kp)
233233
{
234234
action_fn fn = (action_fn) kp->arg;
235-
int rv;
235+
int rv, len;
236236

237237
rv = fn(NULL, buffer);
238238
if (rv)
239239
return rv;
240-
return strlen(buffer);
240+
241+
len = strlen(buffer);
242+
buffer[len++] = '\n';
243+
buffer[len] = 0;
244+
245+
return len;
241246
}
242247

243248

0 commit comments

Comments
 (0)