Skip to content

Commit 63c3212

Browse files
cpackham-atlnzlinusw
authored andcommitted
pinctrl: mvebu: Fix i2c sda definition for 98DX3236
Per the datasheet the i2c functions use MPP_Sel=0x1. They are documented as using MPP_Sel=0x4 as well but mixing 0x1 and 0x4 is clearly wrong. On the board tested 0x4 resulted in a non-functioning i2c bus so stick with 0x1 which works. Fixes: d7ae8f8 ("pinctrl: mvebu: pinctrl driver for 98DX3236 SoC") Signed-off-by: Chris Packham <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent d012a71 commit 63c3212

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pinctrl/mvebu/pinctrl-armada-xp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ static struct mvebu_mpp_mode mv98dx3236_mpp_modes[] = {
414414
MPP_VAR_FUNCTION(0x1, "i2c0", "sck", V_98DX3236_PLUS)),
415415
MPP_MODE(15,
416416
MPP_VAR_FUNCTION(0x0, "gpio", NULL, V_98DX3236_PLUS),
417-
MPP_VAR_FUNCTION(0x4, "i2c0", "sda", V_98DX3236_PLUS)),
417+
MPP_VAR_FUNCTION(0x1, "i2c0", "sda", V_98DX3236_PLUS)),
418418
MPP_MODE(16,
419419
MPP_VAR_FUNCTION(0x0, "gpo", NULL, V_98DX3236_PLUS),
420420
MPP_VAR_FUNCTION(0x4, "dev", "oe", V_98DX3236_PLUS)),

0 commit comments

Comments
 (0)