Skip to content

Commit 63f0cba

Browse files
dtatuleamstsirkin
authored andcommitted
vdpa/mlx5: Make setup/teardown_vq_resources() symmetrical
... by changing the setup_vq_resources() parameter type. Reviewed-by: Cosmin Ratiu <[email protected]> Acked-by: Eugenio Pérez <[email protected]> Signed-off-by: Dragos Tatulea <[email protected]> Message-Id: <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
1 parent 1f5d647 commit 63f0cba

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/vdpa/mlx5/net/mlx5_vnet.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ static bool is_index_valid(struct mlx5_vdpa_dev *mvdev, u16 idx)
146146

147147
static void free_fixed_resources(struct mlx5_vdpa_net *ndev);
148148
static void init_mvqs(struct mlx5_vdpa_net *ndev);
149-
static int setup_vq_resources(struct mlx5_vdpa_dev *mvdev);
149+
static int setup_vq_resources(struct mlx5_vdpa_net *ndev);
150150
static void teardown_vq_resources(struct mlx5_vdpa_net *ndev);
151151

152152
static bool mlx5_vdpa_debug;
@@ -2862,7 +2862,7 @@ static int mlx5_vdpa_change_map(struct mlx5_vdpa_dev *mvdev,
28622862

28632863
if (teardown) {
28642864
restore_channels_info(ndev);
2865-
err = setup_vq_resources(mvdev);
2865+
err = setup_vq_resources(ndev);
28662866
if (err)
28672867
return err;
28682868
}
@@ -2873,9 +2873,9 @@ static int mlx5_vdpa_change_map(struct mlx5_vdpa_dev *mvdev,
28732873
}
28742874

28752875
/* reslock must be held for this function */
2876-
static int setup_vq_resources(struct mlx5_vdpa_dev *mvdev)
2876+
static int setup_vq_resources(struct mlx5_vdpa_net *ndev)
28772877
{
2878-
struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);
2878+
struct mlx5_vdpa_dev *mvdev = &ndev->mvdev;
28792879
int err;
28802880

28812881
WARN_ON(!rwsem_is_locked(&ndev->reslock));
@@ -2997,7 +2997,7 @@ static void mlx5_vdpa_set_status(struct vdpa_device *vdev, u8 status)
29972997
goto err_setup;
29982998
}
29992999
register_link_notifier(ndev);
3000-
err = setup_vq_resources(mvdev);
3000+
err = setup_vq_resources(ndev);
30013001
if (err) {
30023002
mlx5_vdpa_warn(mvdev, "failed to setup driver\n");
30033003
goto err_driver;

0 commit comments

Comments
 (0)