drm/panfrost: Fix runtime PM imbalance on error

dinghaoliu · Steven Price · commit 64092598c456 · 2020-06-19T11:00:02.000+01:00
The caller expects panfrost_job_hw_submit() to increase runtime PM usage counter. The refcount decrement on the error branch of WARN_ON() will break the counter balance and needs to be removed. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Reviewed-by: Steven Price <steven.price@arm.com> Signed-off-by: Steven Price <steven.price@arm.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200522134109.27204-1-dinghao.liu@zju.edu.cn
diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
@@ -152,7 +152,6 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js)
 		return;
 
 	if (WARN_ON(job_read(pfdev, JS_COMMAND_NEXT(js)))) {
-		pm_runtime_put_sync_autosuspend(pfdev->dev);
 		return;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,6 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js)`
`152`	`152`	`return;`
`153`	`153`
`154`	`154`	`if (WARN_ON(job_read(pfdev, JS_COMMAND_NEXT(js)))) {`
`155`		`- pm_runtime_put_sync_autosuspend(pfdev->dev);`
`156`	`155`	`return;`
`157`	`156`	`}`
`158`	`157`