Skip to content

Commit 6429ccd

Browse files
Gilad Ben-Yossefherbertx
authored andcommitted
crypto: ccree - remove ancient TODO remarks
Remove left over ancient and now misleading TODO remarks. Signed-off-by: Gilad Ben-Yossef <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
1 parent 8b9d6e9 commit 6429ccd

File tree

5 files changed

+0
-8
lines changed

5 files changed

+0
-8
lines changed

drivers/crypto/ccree/cc_aead.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1990,7 +1990,6 @@ static int cc_proc_aead(struct aead_request *req,
19901990
/* Load MLLI tables to SRAM if necessary */
19911991
cc_mlli_to_sram(req, desc, &seq_len);
19921992

1993-
/*TODO: move seq len by reference */
19941993
switch (ctx->auth_mode) {
19951994
case DRV_HASH_SHA1:
19961995
case DRV_HASH_SHA256:

drivers/crypto/ccree/cc_buffer_mgr.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,6 @@ static int cc_aead_chain_iv(struct cc_drvdata *drvdata,
606606

607607
dev_dbg(dev, "Mapped iv %u B at va=%pK to dma=%pad\n",
608608
hw_iv_size, req->iv, &areq_ctx->gen_ctx.iv_dma_addr);
609-
// TODO: what about CTR?? ask Ron
610609
if (do_chain && areq_ctx->plaintext_authenticate_only) {
611610
struct crypto_aead *tfm = crypto_aead_reqtfm(req);
612611
unsigned int iv_size_to_authenc = crypto_aead_ivsize(tfm);
@@ -1225,7 +1224,6 @@ int cc_map_hash_request_final(struct cc_drvdata *drvdata, void *ctx,
12251224
return 0;
12261225
}
12271226

1228-
/*TODO: copy data in case that buffer is enough for operation */
12291227
/* map the previous buffer */
12301228
if (*curr_buff_cnt) {
12311229
rc = cc_set_hash_buf(dev, areq_ctx, curr_buff, *curr_buff_cnt,

drivers/crypto/ccree/cc_cipher.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -859,7 +859,6 @@ static int cc_cipher_process(struct skcipher_request *req,
859859

860860
/* STAT_PHASE_0: Init and sanity checks */
861861

862-
/* TODO: check data length according to mode */
863862
if (validate_data_size(ctx_p, nbytes)) {
864863
dev_dbg(dev, "Unsupported data size %d.\n", nbytes);
865864
rc = -EINVAL;

drivers/crypto/ccree/cc_hash.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,6 @@ static int cc_fin_result(struct cc_hw_desc *desc, struct ahash_request *req,
349349
/* Get final MAC result */
350350
hw_desc_init(&desc[idx]);
351351
set_hash_cipher_mode(&desc[idx], ctx->hw_mode, ctx->hash_mode);
352-
/* TODO */
353352
set_dout_dlli(&desc[idx], state->digest_result_dma_addr, digestsize,
354353
NS_BIT, 1);
355354
set_queue_last_ind(ctx->drvdata, &desc[idx]);
@@ -1319,7 +1318,6 @@ static int cc_mac_final(struct ahash_request *req)
13191318

13201319
/* Get final MAC result */
13211320
hw_desc_init(&desc[idx]);
1322-
/* TODO */
13231321
set_dout_dlli(&desc[idx], state->digest_result_dma_addr,
13241322
digestsize, NS_BIT, 1);
13251323
set_queue_last_ind(ctx->drvdata, &desc[idx]);
@@ -1401,7 +1399,6 @@ static int cc_mac_finup(struct ahash_request *req)
14011399

14021400
/* Get final MAC result */
14031401
hw_desc_init(&desc[idx]);
1404-
/* TODO */
14051402
set_dout_dlli(&desc[idx], state->digest_result_dma_addr,
14061403
digestsize, NS_BIT, 1);
14071404
set_queue_last_ind(ctx->drvdata, &desc[idx]);

drivers/crypto/ccree/cc_request_mgr.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,6 @@ static void cc_do_send_request(struct cc_drvdata *drvdata,
296296
req_mgr_h->req_queue[req_mgr_h->req_queue_head] = *cc_req;
297297
req_mgr_h->req_queue_head = (req_mgr_h->req_queue_head + 1) &
298298
(MAX_REQUEST_QUEUE_SIZE - 1);
299-
/* TODO: Use circ_buf.h ? */
300299

301300
dev_dbg(dev, "Enqueue request head=%u\n", req_mgr_h->req_queue_head);
302301

0 commit comments

Comments
 (0)