Skip to content

Commit 642d94c

Browse files
author
Ingo Molnar
committed
x86/build: Declutter the build output
We have some really ancient debug printouts in the x86 boot image build code: Setup is 14108 bytes (padded to 14336 bytes). System is 8802 kB CRC 27e909d4 None of these ever helped debug any sort of breakage that I know of, and they clutter the build output. Remove them - if anyone needs the see the various interim stages of this to debug an obscure bug, they can add these printfs and more. We still keep this one: Kernel: arch/x86/boot/bzImage is ready (#19) As a sentimental leftover, plus the '#19' build count tag is mildly useful. Signed-off-by: Ingo Molnar <[email protected]> Cc: [email protected] Cc: [email protected]
1 parent 18445bf commit 642d94c

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

arch/x86/boot/tools/build.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -416,16 +416,13 @@ int main(int argc, char ** argv)
416416
/* Set the default root device */
417417
put_unaligned_le16(DEFAULT_ROOT_DEV, &buf[508]);
418418

419-
printf("Setup is %d bytes (padded to %d bytes).\n", c, i);
420-
421419
/* Open and stat the kernel file */
422420
fd = open(argv[2], O_RDONLY);
423421
if (fd < 0)
424422
die("Unable to open `%s': %m", argv[2]);
425423
if (fstat(fd, &sb))
426424
die("Unable to stat `%s': %m", argv[2]);
427425
sz = sb.st_size;
428-
printf("System is %d kB\n", (sz+1023)/1024);
429426
kernel = mmap(NULL, sz, PROT_READ, MAP_SHARED, fd, 0);
430427
if (kernel == MAP_FAILED)
431428
die("Unable to mmap '%s': %m", argv[2]);
@@ -488,7 +485,6 @@ int main(int argc, char ** argv)
488485
}
489486

490487
/* Write the CRC */
491-
printf("CRC %x\n", crc);
492488
put_unaligned_le32(crc, buf);
493489
if (fwrite(buf, 1, 4, dest) != 4)
494490
die("Writing CRC failed");

0 commit comments

Comments
 (0)