Skip to content

Commit 64419ca

Browse files
author
Peter Zijlstra
committed
sched,msm: Convert to sched_set_fifo*()
Because SCHED_FIFO is a broken scheduler model (see previous patches) take away the priority field, the kernel can't possibly make an informed decision. Use sched_set_fifo(); Effectively changes prio from 16 to 50. Cc: [email protected] Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Reviewed-by: Ingo Molnar <[email protected]>
1 parent 6e6d6ef commit 64419ca

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

drivers/gpu/drm/msm/msm_drv.c

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,6 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv)
389389
struct msm_kms *kms;
390390
struct msm_mdss *mdss;
391391
int ret, i;
392-
struct sched_param param;
393392

394393
ddev = drm_dev_alloc(drv, dev);
395394
if (IS_ERR(ddev)) {
@@ -495,12 +494,6 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv)
495494
ddev->mode_config.funcs = &mode_config_funcs;
496495
ddev->mode_config.helper_private = &mode_config_helper_funcs;
497496

498-
/**
499-
* this priority was found during empiric testing to have appropriate
500-
* realtime scheduling to process display updates and interact with
501-
* other real time and normal priority task
502-
*/
503-
param.sched_priority = 16;
504497
for (i = 0; i < priv->num_crtcs; i++) {
505498
/* initialize event thread */
506499
priv->event_thread[i].crtc_id = priv->crtcs[i]->base.id;
@@ -516,8 +509,7 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv)
516509
goto err_msm_uninit;
517510
}
518511

519-
ret = sched_setscheduler(priv->event_thread[i].thread,
520-
SCHED_FIFO, &param);
512+
ret = sched_set_fifo(priv->event_thread[i].thread);
521513
if (ret)
522514
dev_warn(dev, "event_thread set priority failed:%d\n",
523515
ret);

0 commit comments

Comments
 (0)