Skip to content

Commit 64b3eaf

Browse files
bjorn-helgaasbostrovs
authored andcommitted
xenbus: Use dev_printk() when possible
Use dev_printk() when possible to include device and driver information in the conventional format. Add "#define dev_fmt" to preserve KBUILD_MODNAME in messages. No functional change intended. Signed-off-by: Bjorn Helgaas <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Boris Ostrovsky <[email protected]> Signed-off-by: Boris Ostrovsky <[email protected]>
1 parent 6904945 commit 64b3eaf

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

drivers/xen/xenbus/xenbus_probe.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
*/
3232

3333
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
34+
#define dev_fmt pr_fmt
3435

3536
#define DPRINTK(fmt, args...) \
3637
pr_debug("xenbus_probe (%s:%d) " fmt ".\n", \
@@ -608,7 +609,7 @@ int xenbus_dev_suspend(struct device *dev)
608609
if (drv->suspend)
609610
err = drv->suspend(xdev);
610611
if (err)
611-
pr_warn("suspend %s failed: %i\n", dev_name(dev), err);
612+
dev_warn(dev, "suspend failed: %i\n", err);
612613
return 0;
613614
}
614615
EXPORT_SYMBOL_GPL(xenbus_dev_suspend);
@@ -627,8 +628,7 @@ int xenbus_dev_resume(struct device *dev)
627628
drv = to_xenbus_driver(dev->driver);
628629
err = talk_to_otherend(xdev);
629630
if (err) {
630-
pr_warn("resume (talk_to_otherend) %s failed: %i\n",
631-
dev_name(dev), err);
631+
dev_warn(dev, "resume (talk_to_otherend) failed: %i\n", err);
632632
return err;
633633
}
634634

@@ -637,15 +637,14 @@ int xenbus_dev_resume(struct device *dev)
637637
if (drv->resume) {
638638
err = drv->resume(xdev);
639639
if (err) {
640-
pr_warn("resume %s failed: %i\n", dev_name(dev), err);
640+
dev_warn(dev, "resume failed: %i\n", err);
641641
return err;
642642
}
643643
}
644644

645645
err = watch_otherend(xdev);
646646
if (err) {
647-
pr_warn("resume (watch_otherend) %s failed: %d.\n",
648-
dev_name(dev), err);
647+
dev_warn(dev, "resume (watch_otherend) failed: %d\n", err);
649648
return err;
650649
}
651650

0 commit comments

Comments
 (0)