Skip to content

Commit 64ea30d

Browse files
arndbbebarino
authored andcommitted
clk: imx: fix compile testing imxrt1050
Randconfig testing revealed multiple issues with this driver: ERROR: modpost: missing MODULE_LICENSE() in drivers/clk/imx/clk-imxrt1050.o ERROR: modpost: "imx_clk_hw_pllv3" [drivers/clk/imx/clk-imxrt1050.ko] undefined! ERROR: modpost: "imx_clk_hw_pfd" [drivers/clk/imx/clk-imxrt1050.ko] undefined! Export the necessary symbols from the core clk driver and add the license and author tags. To find this type of problem more easily in the future, also enable building on other platforms, as we do for the other i.MX clk drivers. Signed-off-by: Arnd Bergmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Acked-by: Jesse Taube <[email protected]> Reviewed-by: Abel Vesa <[email protected]> Signed-off-by: Stephen Boyd <[email protected]>
1 parent f89ea8f commit 64ea30d

File tree

4 files changed

+9
-1
lines changed

4 files changed

+9
-1
lines changed

drivers/clk/imx/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ config CLK_IMX93
115115

116116
config CLK_IMXRT1050
117117
tristate "IMXRT1050 CCM Clock Driver"
118-
depends on SOC_IMXRT
118+
depends on SOC_IMXRT || COMPILE_TEST
119119
select MXC_CLK
120120
help
121121
Build the driver for i.MXRT1050 CCM Clock Driver

drivers/clk/imx/clk-imxrt1050.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,3 +167,7 @@ static struct platform_driver imxrt1050_clk_driver = {
167167
},
168168
};
169169
module_platform_driver(imxrt1050_clk_driver);
170+
171+
MODULE_LICENSE("Dual BSD/GPL");
172+
MODULE_AUTHOR("Jesse Taube <[email protected]>");
173+
MODULE_AUTHOR("Giulio Benetti <[email protected]>");

drivers/clk/imx/clk-pfd.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66

77
#include <linux/clk-provider.h>
8+
#include <linux/export.h>
89
#include <linux/io.h>
910
#include <linux/slab.h>
1011
#include <linux/err.h>
@@ -153,3 +154,4 @@ struct clk_hw *imx_clk_hw_pfd(const char *name, const char *parent_name,
153154

154155
return hw;
155156
}
157+
EXPORT_SYMBOL_GPL(imx_clk_hw_pfd);

drivers/clk/imx/clk-pllv3.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
#include <linux/clk-provider.h>
88
#include <linux/delay.h>
9+
#include <linux/export.h>
910
#include <linux/io.h>
1011
#include <linux/iopoll.h>
1112
#include <linux/slab.h>
@@ -486,3 +487,4 @@ struct clk_hw *imx_clk_hw_pllv3(enum imx_pllv3_type type, const char *name,
486487

487488
return hw;
488489
}
490+
EXPORT_SYMBOL_GPL(imx_clk_hw_pllv3);

0 commit comments

Comments
 (0)