Skip to content

Commit 64febc5

Browse files
noglitchdavem330
authored andcommitted
net: macb: fix macb_suspend() by removing call to netif_carrier_off()
As we now use the phylink call to phylink_stop() in the non-WoL path, there is no need for this call to netif_carrier_off() anymore. It can disturb the underlying phylink FSM. Fixes: 7897b07 ("net: macb: convert to phylink") Cc: Claudiu Beznea <[email protected]> Cc: Harini Katakam <[email protected]> Cc: Antoine Tenart <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Signed-off-by: Nicolas Ferre <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 253fe09 commit 64febc5

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/net/ethernet/cadence/macb_main.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4604,7 +4604,6 @@ static int __maybe_unused macb_suspend(struct device *dev)
46044604
bp->pm_data.scrt2 = gem_readl_n(bp, ETHT, SCRT2_ETHT);
46054605
}
46064606

4607-
netif_carrier_off(netdev);
46084607
if (bp->ptp_info)
46094608
bp->ptp_info->ptp_remove(netdev);
46104609
pm_runtime_force_suspend(dev);

0 commit comments

Comments
 (0)