Skip to content

Commit 65135e2

Browse files
javiercarrascocruzlag-linaro
authored andcommitted
leds: cr0014114: Switch to device_for_each_child_node_scoped()
Switch to device_for_each_child_node_scoped() to simplify the code by removing the need for calls to fwnode_handle_put() in the error paths. This also prevents possible memory leaks if new error paths are added without the required call to fwnode_handle_put(). Signed-off-by: Javier Carrasco <[email protected]> Link: https://lore.kernel.org/r/20240927-leds_device_for_each_child_node_scoped-v1-5-95c0614b38c8@gmail.com Signed-off-by: Lee Jones <[email protected]>
1 parent a361af3 commit 65135e2

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/leds/leds-cr0014114.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,11 +181,10 @@ static int cr0014114_probe_dt(struct cr0014114 *priv)
181181
{
182182
size_t i = 0;
183183
struct cr0014114_led *led;
184-
struct fwnode_handle *child;
185184
struct led_init_data init_data = {};
186185
int ret;
187186

188-
device_for_each_child_node(priv->dev, child) {
187+
device_for_each_child_node_scoped(priv->dev, child) {
189188
led = &priv->leds[i];
190189

191190
led->priv = priv;
@@ -201,7 +200,6 @@ static int cr0014114_probe_dt(struct cr0014114 *priv)
201200
if (ret) {
202201
dev_err(priv->dev,
203202
"failed to register LED device, err %d", ret);
204-
fwnode_handle_put(child);
205203
return ret;
206204
}
207205

0 commit comments

Comments
 (0)