Skip to content

Commit 65315ec

Browse files
kwilczynskiLorenzo Pieralisi
authored andcommitted
PCI: imx6: Remove unused assignment to variable ret
Previously, the maximum link speed was set following an "fsl,max-link-speed" property read, and should the read failed, then the PCIe generation was manually set to PCIe Gen1 and thus limiting the link speed to 2.5 GT/s. Code refactoring completed in the commit 39bc500 ("PCI: dwc: Centralize link gen setting") changed to the logic that was previously used to limit the maximum link speed leaving behind an unused assignment to a variable "ret". Since the value returned from the of_property_read_u32() and stored in the variable "ret" is never used in any meaningful way, and it's also immediately reassigned in the code that follows, the assignment can be removed. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Krzysztof Wilczyński <[email protected]> Signed-off-by: Lorenzo Pieralisi <[email protected]>
1 parent e4e737b commit 65315ec

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pci/controller/dwc/pci-imx6.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1132,7 +1132,7 @@ static int imx6_pcie_probe(struct platform_device *pdev)
11321132

11331133
/* Limit link speed */
11341134
pci->link_gen = 1;
1135-
ret = of_property_read_u32(node, "fsl,max-link-speed", &pci->link_gen);
1135+
of_property_read_u32(node, "fsl,max-link-speed", &pci->link_gen);
11361136

11371137
imx6_pcie->vpcie = devm_regulator_get_optional(&pdev->dev, "vpcie");
11381138
if (IS_ERR(imx6_pcie->vpcie)) {

0 commit comments

Comments
 (0)