Skip to content

Commit 6588213

Browse files
krzkbroonie
authored andcommitted
ASoC: qcom: q6prm: fix incorrect clk_root passed to ADSP
The second to last argument is clk_root (root of the clock), however the code called q6prm_request_lpass_clock() with clk_attr instead (copy-paste error). This effectively was passing value of 1 as root clock which worked on some of the SoCs (e.g. SM8450) but fails on others, depending on the ADSP. For example on SM8550 this "1" as root clock is not accepted and results in errors coming from ADSP. Fixes: 2f20640 ("ASoC: qdsp6: qdsp6: q6prm: handle clk disable correctly") Cc: <[email protected]> Signed-off-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Srinivas Kandagatla <[email protected]> Tested-by: Srinivas Kandagatla <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 03d0f97 commit 6588213

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

sound/soc/qcom/qdsp6/q6prm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,9 @@ int q6prm_set_lpass_clock(struct device *dev, int clk_id, int clk_attr, int clk_
184184
unsigned int freq)
185185
{
186186
if (freq)
187-
return q6prm_request_lpass_clock(dev, clk_id, clk_attr, clk_attr, freq);
187+
return q6prm_request_lpass_clock(dev, clk_id, clk_attr, clk_root, freq);
188188

189-
return q6prm_release_lpass_clock(dev, clk_id, clk_attr, clk_attr, freq);
189+
return q6prm_release_lpass_clock(dev, clk_id, clk_attr, clk_root, freq);
190190
}
191191
EXPORT_SYMBOL_GPL(q6prm_set_lpass_clock);
192192

0 commit comments

Comments
 (0)