Skip to content

Commit 658c82c

Browse files
lumagandersson
authored andcommitted
clk: qcom: gpucc-sc7180: fix clk_dis_wait being programmed for CX GDSC
The gdsc_init() function will rewrite the CLK_DIS_WAIT field while registering the GDSC (writing the value 0x2 by default). This will override the setting done in the driver's probe function. Set cx_gdsc.clk_dis_wait_val to 8 to follow the intention of the probe function. Fixes: 745ff06 ("clk: qcom: Add graphics clock controller driver for SC7180") Reviewed-by: Stephen Boyd <[email protected]> Signed-off-by: Dmitry Baryshkov <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]> Signed-off-by: Bjorn Andersson <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 1519c0a commit 658c82c

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

drivers/clk/qcom/gpucc-sc7180.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
#define CX_GMU_CBCR_SLEEP_SHIFT 4
2222
#define CX_GMU_CBCR_WAKE_MASK 0xF
2323
#define CX_GMU_CBCR_WAKE_SHIFT 8
24-
#define CLK_DIS_WAIT_SHIFT 12
25-
#define CLK_DIS_WAIT_MASK (0xf << CLK_DIS_WAIT_SHIFT)
2624

2725
enum {
2826
P_BI_TCXO,
@@ -160,6 +158,7 @@ static struct clk_branch gpu_cc_cxo_clk = {
160158
static struct gdsc cx_gdsc = {
161159
.gdscr = 0x106c,
162160
.gds_hw_ctrl = 0x1540,
161+
.clk_dis_wait_val = 8,
163162
.pd = {
164163
.name = "cx_gdsc",
165164
},
@@ -242,10 +241,6 @@ static int gpu_cc_sc7180_probe(struct platform_device *pdev)
242241
value = 0xF << CX_GMU_CBCR_WAKE_SHIFT | 0xF << CX_GMU_CBCR_SLEEP_SHIFT;
243242
regmap_update_bits(regmap, 0x1098, mask, value);
244243

245-
/* Configure clk_dis_wait for gpu_cx_gdsc */
246-
regmap_update_bits(regmap, 0x106c, CLK_DIS_WAIT_MASK,
247-
8 << CLK_DIS_WAIT_SHIFT);
248-
249244
return qcom_cc_really_probe(pdev, &gpu_cc_sc7180_desc, regmap);
250245
}
251246

0 commit comments

Comments
 (0)