x86/lib: Fix compiler and kernel-doc warnings

aweeraman · Ingo Molnar · commit 65c24d7b0f91 · 2023-01-03T18:46:21.000+01:00
Fix the following W=1 warnings: arch/x86/lib/cmdline.c: - Include <asm/cmdline.h> to fix missing-prototypes warnings. - Update comment for __cmdline_find_option_bool to fix a kernel-doc warning. Signed-off-by: Anuradha Weeraman <anuradha@debian.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Link: https://lore.kernel.org/r/20230103114725.108431-1-anuradha@debian.org
diff --git a/arch/x86/lib/cmdline.c b/arch/x86/lib/cmdline.c
@@ -7,16 +7,18 @@
 #include <linux/string.h>
 #include <linux/ctype.h>
 #include <asm/setup.h>
+#include <asm/cmdline.h>
 
 static inline int myisspace(u8 c)
 {
 	return c <= ' ';	/* Close enough approximation */
 }
 
-/**
+/*
  * Find a boolean option (like quiet,noapic,nosmp....)
  *
  * @cmdline: the cmdline string
+ * @max_cmdline_size: the maximum size of cmdline
  * @option: option string to look for
  *
  * Returns the position of that @option (starts counting with 1)

Original file line number	Diff line number	Diff line change
`@@ -7,16 +7,18 @@`
`7`	`7`	`#include <linux/string.h>`
`8`	`8`	`#include <linux/ctype.h>`
`9`	`9`	`#include <asm/setup.h>`
	`10`	`+#include <asm/cmdline.h>`
`10`	`11`
`11`	`12`	`static inline int myisspace(u8 c)`
`12`	`13`	`{`
`13`	`14`	`return c <= ' '; /* Close enough approximation */`
`14`	`15`	`}`
`15`	`16`
`16`		`-/**`
	`17`	`+/*`
`17`	`18`	`* Find a boolean option (like quiet,noapic,nosmp....)`
`18`	`19`	`*`
`19`	`20`	`* @cmdline: the cmdline string`
	`21`	`+ * @max_cmdline_size: the maximum size of cmdline`
`20`	`22`	`* @option: option string to look for`
`21`	`23`	`*`
`22`	`24`	`* Returns the position of that @option (starts counting with 1)`