fbdev: omapfb: Use of_property_present() to test existence of DT property

krzk · hdeller · commit 65ea3b4d3836 · 2025-01-12T18:12:34.000+01:00
of_property_read_bool() should be used only on boolean properties.

Cc: Rob Herring &lt;robh@kernel.org&gt;
Signed-off-by: Krzysztof Kozlowski &lt;krzysztof.kozlowski@linaro.org&gt;
Signed-off-by: Helge Deller &lt;deller@gmx.de&gt;
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dispc.c b/drivers/video/fbdev/omap2/omapfb/dss/dispc.c
@@ -3933,7 +3933,7 @@ static int dispc_bind(struct device *dev, struct device *master, void *data)
 		return -ENODEV;
 	}
 
-	if (np && of_property_read_bool(np, "syscon-pol")) {
+	if (np && of_property_present(np, "syscon-pol")) {
 		dispc.syscon_pol = syscon_regmap_lookup_by_phandle(np, "syscon-pol");
 		if (IS_ERR(dispc.syscon_pol)) {
 			dev_err(&pdev->dev, "failed to get syscon-pol regmap\n");

Original file line number	Diff line number	Diff line change
`@@ -3933,7 +3933,7 @@ static int dispc_bind(struct device dev, struct device master, void *data)`
`3933`	`3933`	`return -ENODEV;`
`3934`	`3934`	`}`
`3935`	`3935`
`3936`		`- if (np && of_property_read_bool(np, "syscon-pol")) {`
	`3936`	`+ if (np && of_property_present(np, "syscon-pol")) {`
`3937`	`3937`	`dispc.syscon_pol = syscon_regmap_lookup_by_phandle(np, "syscon-pol");`
`3938`	`3938`	`if (IS_ERR(dispc.syscon_pol)) {`
`3939`	`3939`	`dev_err(&pdev->dev, "failed to get syscon-pol regmap\n");`