Skip to content

Commit 663218a

Browse files
krishna-ejgunthorpe
authored andcommitted
RDMA/siw: Remove unwanted WARN_ON in siw_cm_llp_data_ready()
Warnings like below can fill up the dmesg while disconnecting RDMA connections. Hence, remove the unwanted WARN_ON. WARNING: CPU: 6 PID: 0 at drivers/infiniband/sw/siw/siw_cm.c:1229 siw_cm_llp_data_ready+0xc1/0xd0 [siw] RIP: 0010:siw_cm_llp_data_ready+0xc1/0xd0 [siw] Call Trace: <IRQ> tcp_data_queue+0x226/0xb40 tcp_rcv_established+0x220/0x620 tcp_v4_do_rcv+0x12a/0x1e0 tcp_v4_rcv+0xb05/0xc00 ip_local_deliver_finish+0x69/0x210 ip_local_deliver+0x6b/0xe0 ip_rcv+0x273/0x362 __netif_receive_skb_core+0xb35/0xc30 netif_receive_skb_internal+0x3d/0xb0 napi_gro_frags+0x13b/0x200 t4_ethrx_handler+0x433/0x7d0 [cxgb4] process_responses+0x318/0x580 [cxgb4] napi_rx_handler+0x14/0x100 [cxgb4] net_rx_action+0x149/0x3b0 __do_softirq+0xe3/0x30a irq_exit+0x100/0x110 do_IRQ+0x7f/0xe0 common_interrupt+0xf/0xf </IRQ> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Krishnamraju Eraparaju <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent d219fac commit 663218a

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/infiniband/sw/siw/siw_cm.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1225,10 +1225,9 @@ static void siw_cm_llp_data_ready(struct sock *sk)
12251225
read_lock(&sk->sk_callback_lock);
12261226

12271227
cep = sk_to_cep(sk);
1228-
if (!cep) {
1229-
WARN_ON(1);
1228+
if (!cep)
12301229
goto out;
1231-
}
1230+
12321231
siw_dbg_cep(cep, "state: %d\n", cep->state);
12331232

12341233
switch (cep->state) {

0 commit comments

Comments
 (0)