Skip to content

Commit 663e36f

Browse files
J. Bruce Fieldschucklever
authored andcommitted
nfsd4: kill warnings on testing stateids with mismatched clientids
It's normal for a client to test a stateid from a previous instance, e.g. after a network partition. Signed-off-by: J. Bruce Fields <[email protected]> Reviewed-by: Benjamin Coddington <[email protected]> Signed-off-by: Chuck Lever <[email protected]>
1 parent 6cbfad5 commit 663e36f

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

fs/nfsd/nfs4state.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5531,15 +5531,8 @@ static __be32 nfsd4_validate_stateid(struct nfs4_client *cl, stateid_t *stateid)
55315531
if (ZERO_STATEID(stateid) || ONE_STATEID(stateid) ||
55325532
CLOSE_STATEID(stateid))
55335533
return status;
5534-
/* Client debugging aid. */
5535-
if (!same_clid(&stateid->si_opaque.so_clid, &cl->cl_clientid)) {
5536-
char addr_str[INET6_ADDRSTRLEN];
5537-
rpc_ntop((struct sockaddr *)&cl->cl_addr, addr_str,
5538-
sizeof(addr_str));
5539-
pr_warn_ratelimited("NFSD: client %s testing state ID "
5540-
"with incorrect client ID\n", addr_str);
5534+
if (!same_clid(&stateid->si_opaque.so_clid, &cl->cl_clientid))
55415535
return status;
5542-
}
55435536
spin_lock(&cl->cl_lock);
55445537
s = find_stateid_locked(cl, stateid);
55455538
if (!s)

0 commit comments

Comments
 (0)