Skip to content

Commit 665e7c7

Browse files
BobBeckettShawn Guo
authored andcommitted
ARM: dts/imx6q-bx50v3: Set display interface clock parents
Avoid LDB and IPU DI clocks both using the same parent. LDB requires pasthrough clock to avoid breaking timing while IPU DI does not. Force IPU DI clocks to use IMX6QDL_CLK_PLL2_PFD0_352M as parent and LDB to use IMX6QDL_CLK_PLL5_VIDEO_DIV. This fixes an issue where attempting atomic modeset while using HDMI and display port at the same time causes LDB clock programming to destroy the programming of HDMI that was done during the same modeset. Cc: [email protected] Signed-off-by: Robert Beckett <[email protected]> [Use IMX6QDL_CLK_PLL2_PFD0_352M instead of IMX6QDL_CLK_PLL2_PFD2_396M originally chosen by Robert Beckett to avoid affecting eMMC clock by DRM atomic updates] Signed-off-by: Ian Ray <[email protected]> [Squash Robert's and Ian's commits for bisectability, update patch description and add stable tag] Signed-off-by: Sebastian Reichel <[email protected]> Signed-off-by: Shawn Guo <[email protected]>
1 parent 1248c86 commit 665e7c7

File tree

4 files changed

+15
-25
lines changed

4 files changed

+15
-25
lines changed

arch/arm/boot/dts/imx6q-b450v3.dts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,6 @@
6565
};
6666
};
6767

68-
&clks {
69-
assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>,
70-
<&clks IMX6QDL_CLK_LDB_DI1_SEL>;
71-
assigned-clock-parents = <&clks IMX6QDL_CLK_PLL3_USB_OTG>,
72-
<&clks IMX6QDL_CLK_PLL3_USB_OTG>;
73-
};
74-
7568
&ldb {
7669
status = "okay";
7770

arch/arm/boot/dts/imx6q-b650v3.dts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,6 @@
6565
};
6666
};
6767

68-
&clks {
69-
assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>,
70-
<&clks IMX6QDL_CLK_LDB_DI1_SEL>;
71-
assigned-clock-parents = <&clks IMX6QDL_CLK_PLL3_USB_OTG>,
72-
<&clks IMX6QDL_CLK_PLL3_USB_OTG>;
73-
};
74-
7568
&ldb {
7669
status = "okay";
7770

arch/arm/boot/dts/imx6q-b850v3.dts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -53,17 +53,6 @@
5353
};
5454
};
5555

56-
&clks {
57-
assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>,
58-
<&clks IMX6QDL_CLK_LDB_DI1_SEL>,
59-
<&clks IMX6QDL_CLK_IPU1_DI0_PRE_SEL>,
60-
<&clks IMX6QDL_CLK_IPU2_DI0_PRE_SEL>;
61-
assigned-clock-parents = <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>,
62-
<&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>,
63-
<&clks IMX6QDL_CLK_PLL2_PFD2_396M>,
64-
<&clks IMX6QDL_CLK_PLL2_PFD2_396M>;
65-
};
66-
6756
&ldb {
6857
fsl,dual-channel;
6958
status = "okay";

arch/arm/boot/dts/imx6q-bx50v3.dtsi

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,3 +377,18 @@
377377
#interrupt-cells = <1>;
378378
};
379379
};
380+
381+
&clks {
382+
assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>,
383+
<&clks IMX6QDL_CLK_LDB_DI1_SEL>,
384+
<&clks IMX6QDL_CLK_IPU1_DI0_PRE_SEL>,
385+
<&clks IMX6QDL_CLK_IPU1_DI1_PRE_SEL>,
386+
<&clks IMX6QDL_CLK_IPU2_DI0_PRE_SEL>,
387+
<&clks IMX6QDL_CLK_IPU2_DI1_PRE_SEL>;
388+
assigned-clock-parents = <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>,
389+
<&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>,
390+
<&clks IMX6QDL_CLK_PLL2_PFD0_352M>,
391+
<&clks IMX6QDL_CLK_PLL2_PFD0_352M>,
392+
<&clks IMX6QDL_CLK_PLL2_PFD0_352M>,
393+
<&clks IMX6QDL_CLK_PLL2_PFD0_352M>;
394+
};

0 commit comments

Comments
 (0)