Skip to content

Commit 6661146

Browse files
larsclausenjic23
authored andcommitted
iio: ad7768-1: Call iio_trigger_notify_done() on error
IIO trigger handlers must call iio_trigger_notify_done() when done. This must be done even when an error occurred. Otherwise the trigger will be seen as busy indefinitely and the trigger handler will never be called again. The ad7768-1 driver neglects to call iio_trigger_notify_done() when there is an error reading the converter data. Fix this by making sure that iio_trigger_notify_done() is included in the error exit path. Fixes: a5f8c7d ("iio: adc: Add AD7768-1 ADC basic support") Signed-off-by: Lars-Peter Clausen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Cc: <[email protected]> Signed-off-by: Jonathan Cameron <[email protected]>
1 parent 67fe295 commit 6661146

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/iio/adc/ad7768-1.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,8 +480,8 @@ static irqreturn_t ad7768_trigger_handler(int irq, void *p)
480480
iio_push_to_buffers_with_timestamp(indio_dev, &st->data.scan,
481481
iio_get_time_ns(indio_dev));
482482

483-
iio_trigger_notify_done(indio_dev->trig);
484483
err_unlock:
484+
iio_trigger_notify_done(indio_dev->trig);
485485
mutex_unlock(&st->lock);
486486

487487
return IRQ_HANDLED;

0 commit comments

Comments
 (0)