Skip to content

Commit 66be40e

Browse files
kuba-moodavem330
authored andcommitted
tcp_metrics: validate source addr length
I don't see anything checking that TCP_METRICS_ATTR_SADDR_IPV4 is at least 4 bytes long, and the policy doesn't have an entry for this attribute at all (neither does it for IPv6 but v6 is manually validated). Reviewed-by: Eric Dumazet <[email protected]> Fixes: 3e7013d ("tcp: metrics: Allow selective get/del of tcp-metrics based on src IP") Signed-off-by: Jakub Kicinski <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1340611 commit 66be40e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

net/ipv4/tcp_metrics.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -619,6 +619,7 @@ static const struct nla_policy tcp_metrics_nl_policy[TCP_METRICS_ATTR_MAX + 1] =
619619
[TCP_METRICS_ATTR_ADDR_IPV4] = { .type = NLA_U32, },
620620
[TCP_METRICS_ATTR_ADDR_IPV6] = { .type = NLA_BINARY,
621621
.len = sizeof(struct in6_addr), },
622+
[TCP_METRICS_ATTR_SADDR_IPV4] = { .type = NLA_U32, },
622623
/* Following attributes are not received for GET/DEL,
623624
* we keep them for reference
624625
*/

0 commit comments

Comments
 (0)