Skip to content

Commit 66ceaa4

Browse files
jbrandebanguy11
authored andcommitted
ice: fix W=1 headers mismatch
make modules W=1 returns: .../ice/ice_txrx_lib.c:448: warning: Function parameter or member 'first_idx' not described in 'ice_finalize_xdp_rx' .../ice/ice_txrx.c:948: warning: Function parameter or member 'ntc' not described in 'ice_get_rx_buf' .../ice/ice_txrx.c:1038: warning: Excess function parameter 'rx_buf' description in 'ice_construct_skb' Fix these warnings by adding and deleting the deviant arguments. Fixes: 2fba7dc ("ice: Add support for XDP multi-buffer on Rx side") Fixes: d7956d8 ("ice: Pull out next_to_clean bump out of ice_put_rx_buf()") CC: Maciej Fijalkowski <[email protected]> Signed-off-by: Jesse Brandeburg <[email protected]> Reviewed-by: Piotr Raczynski <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent 917fd7d commit 66ceaa4

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

drivers/net/ethernet/intel/ice/ice_txrx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -938,6 +938,7 @@ ice_reuse_rx_page(struct ice_rx_ring *rx_ring, struct ice_rx_buf *old_buf)
938938
* ice_get_rx_buf - Fetch Rx buffer and synchronize data for use
939939
* @rx_ring: Rx descriptor ring to transact packets on
940940
* @size: size of buffer to add to skb
941+
* @ntc: index of next to clean element
941942
*
942943
* This function will pull an Rx buffer from the ring and synchronize it
943944
* for use by the CPU.
@@ -1026,7 +1027,6 @@ ice_build_skb(struct ice_rx_ring *rx_ring, struct xdp_buff *xdp)
10261027
/**
10271028
* ice_construct_skb - Allocate skb and populate it
10281029
* @rx_ring: Rx descriptor ring to transact packets on
1029-
* @rx_buf: Rx buffer to pull data from
10301030
* @xdp: xdp_buff pointing to the data
10311031
*
10321032
* This function allocates an skb. It then populates it with the page

drivers/net/ethernet/intel/ice/ice_txrx_lib.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -438,6 +438,7 @@ int __ice_xmit_xdp_ring(struct xdp_buff *xdp, struct ice_tx_ring *xdp_ring,
438438
* ice_finalize_xdp_rx - Bump XDP Tx tail and/or flush redirect map
439439
* @xdp_ring: XDP ring
440440
* @xdp_res: Result of the receive batch
441+
* @first_idx: index to write from caller
441442
*
442443
* This function bumps XDP Tx tail and/or flush redirect map, and
443444
* should be called when a batch of packets has been processed in the

0 commit comments

Comments
 (0)