Skip to content

Commit 66ec4c1

Browse files
vsyrjalaAndi Shyti
authored andcommitted
drm/i915: Document which RING_FAULT bits apply to which platforms
The RING_FAULT bits have change a bit over the years. Document which platforms use which bits. Signed-off-by: Ville Syrjälä <[email protected]> Reviewed-by: Andi Shyti <[email protected]> Signed-off-by: Andi Shyti <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent f46fa84 commit 66ec4c1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/gpu/drm/i915/gt/intel_gt_regs.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -326,10 +326,10 @@
326326
_RING_FAULT_REG_VCS, \
327327
_RING_FAULT_REG_VECS, \
328328
_RING_FAULT_REG_BCS))
329-
#define RING_FAULT_ENGINE_ID_MASK REG_GENMASK(16, 12)
330-
#define RING_FAULT_GTTSEL_MASK REG_BIT(11)
329+
#define RING_FAULT_ENGINE_ID_MASK REG_GENMASK(16, 12) /* bdw+ */
330+
#define RING_FAULT_GTTSEL_MASK REG_BIT(11) /* pre-bdw */
331331
#define RING_FAULT_SRCID_MASK REG_GENMASK(10, 3)
332-
#define RING_FAULT_FAULT_TYPE_MASK REG_GENMASK(2, 1)
332+
#define RING_FAULT_FAULT_TYPE_MASK REG_GENMASK(2, 1) /* ivb+ */
333333
#define RING_FAULT_VALID REG_BIT(0)
334334

335335
#define ERROR_GEN6 _MMIO(0x40a0)

0 commit comments

Comments
 (0)