Skip to content

Commit 66f1e68

Browse files
fzi-haxelpalmer-dabbelt
authored andcommitted
riscv: Make XIP bootable again
Currently, the XIP kernel seems to fail to boot due to missing XIP_FIXUP and a wrong page_offset value. A superfluous XIP_FIXUP has also been removed. Signed-off-by: Frederik Haxel <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Palmer Dabbelt <[email protected]>
1 parent b85ea95 commit 66f1e68

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

arch/riscv/kernel/head.S

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ relocate_enable_mmu:
8989
/* Compute satp for kernel page tables, but don't load it yet */
9090
srl a2, a0, PAGE_SHIFT
9191
la a1, satp_mode
92+
XIP_FIXUP_OFFSET a1
9293
REG_L a1, 0(a1)
9394
or a2, a2, a1
9495

arch/riscv/mm/init.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,9 @@ void __init mem_init(void)
174174

175175
/* Limit the memory size via mem. */
176176
static phys_addr_t memory_limit;
177+
#ifdef CONFIG_XIP_KERNEL
178+
#define memory_limit (*(phys_addr_t *)XIP_FIXUP(&memory_limit))
179+
#endif /* CONFIG_XIP_KERNEL */
177180

178181
static int __init early_mem(char *p)
179182
{
@@ -952,7 +955,7 @@ static void __init create_fdt_early_page_table(uintptr_t fix_fdt_va,
952955
* setup_vm_final installs the linear mapping. For 32-bit kernel, as the
953956
* kernel is mapped in the linear mapping, that makes no difference.
954957
*/
955-
dtb_early_va = kernel_mapping_pa_to_va(XIP_FIXUP(dtb_pa));
958+
dtb_early_va = kernel_mapping_pa_to_va(dtb_pa);
956959
#endif
957960

958961
dtb_early_pa = dtb_pa;
@@ -1055,9 +1058,9 @@ asmlinkage void __init setup_vm(uintptr_t dtb_pa)
10551058
#endif
10561059

10571060
kernel_map.virt_addr = KERNEL_LINK_ADDR + kernel_map.virt_offset;
1058-
kernel_map.page_offset = _AC(CONFIG_PAGE_OFFSET, UL);
10591061

10601062
#ifdef CONFIG_XIP_KERNEL
1063+
kernel_map.page_offset = PAGE_OFFSET_L3;
10611064
kernel_map.xiprom = (uintptr_t)CONFIG_XIP_PHYS_ADDR;
10621065
kernel_map.xiprom_sz = (uintptr_t)(&_exiprom) - (uintptr_t)(&_xiprom);
10631066

@@ -1067,6 +1070,7 @@ asmlinkage void __init setup_vm(uintptr_t dtb_pa)
10671070

10681071
kernel_map.va_kernel_xip_pa_offset = kernel_map.virt_addr - kernel_map.xiprom;
10691072
#else
1073+
kernel_map.page_offset = _AC(CONFIG_PAGE_OFFSET, UL);
10701074
kernel_map.phys_addr = (uintptr_t)(&_start);
10711075
kernel_map.size = (uintptr_t)(&_end) - kernel_map.phys_addr;
10721076
#endif

0 commit comments

Comments
 (0)