Skip to content

Commit 673b41e

Browse files
rddunlaptorvalds
authored andcommitted
staging/octeon: fix up merge error
There's a semantic conflict in the Octeon staging network driver, which used the skb_reset_tc() function to reset skb state when re-using an skb. But that inline helper function was removed in mainline by commit 2c64605 ("net: Fix CONFIG_NET_CLS_ACT=n and CONFIG_NFT_FWD_NETDEV={y, m} build"). Fix it by using skb_reset_redirect() instead. Also move it out of the This code path only ends up triggering if REUSE_SKBUFFS_WITHOUT_FREE is enabled, which in turn only happens if you don't have CONFIG_NETFILTER configured. Which was how this wasn't caught by the usual allmodconfig builds. Signed-off-by: Randy Dunlap <[email protected]> Reported-by: Stephen Rothwell <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 642e53e commit 673b41e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/staging/octeon/ethernet-tx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,10 +352,10 @@ int cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
352352
skb_dst_set(skb, NULL);
353353
skb_ext_reset(skb);
354354
nf_reset_ct(skb);
355+
skb_reset_redirect(skb);
355356

356357
#ifdef CONFIG_NET_SCHED
357358
skb->tc_index = 0;
358-
skb_reset_tc(skb);
359359
#endif /* CONFIG_NET_SCHED */
360360
#endif /* REUSE_SKBUFFS_WITHOUT_FREE */
361361

0 commit comments

Comments
 (0)