Skip to content

Commit 67776a9

Browse files
Niklas CasselDamien Le Moal
authored andcommitted
ata: remove unused helper ata_id_lba48_enabled()
Not only is this function unused, but even worse, the bit it is checking is actually used for signaling if the feature is supported, not enabled. Therefore, remove the unused helper function ata_id_lba48_enabled(). ata_id_has_lba48() is left unmodified, since this extra supported bit (Bit 10 of word 86) is simply a copy of the bit that ata_id_has_lba48() already checks (Bit 10 of word 83), see ACS-5 r10: 7.13.6.41 Words 85..87, 120: Commands and feature sets supported or enabled Signed-off-by: Niklas Cassel <[email protected]> Signed-off-by: Damien Le Moal <[email protected]>
1 parent 5122e53 commit 67776a9

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

include/linux/ata.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -698,15 +698,6 @@ static inline bool ata_id_has_lba48(const u16 *id)
698698
return id[ATA_ID_COMMAND_SET_2] & (1 << 10);
699699
}
700700

701-
static inline bool ata_id_lba48_enabled(const u16 *id)
702-
{
703-
if (ata_id_has_lba48(id) == 0)
704-
return false;
705-
if ((id[ATA_ID_CSF_DEFAULT] & 0xC000) != 0x4000)
706-
return false;
707-
return id[ATA_ID_CFS_ENABLE_2] & (1 << 10);
708-
}
709-
710701
static inline bool ata_id_hpa_enabled(const u16 *id)
711702
{
712703
/* Yes children, word 83 valid bits cover word 82 data */

0 commit comments

Comments
 (0)