Skip to content

Commit 67ebda8

Browse files
committed
Merge tag 'drm-intel-next-fixes-2023-06-29' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
- Allow DC states along with PW2 only for PWB functionality [adlp+] (Imre Deak) - Fix SSC selection for MPLLA [mtl] (Radhakrishna Sripada) - Use hw.adjusted mode when calculating io/fast wake times [psr] (Jouni Högander) - Apply min softlimit correctly [guc/slpc] (Vinay Belgaumkar) - Assign correct hdcp content type [hdcp] (Suraj Kandpal) - Add missing forward declarations/includes to display power headers (Imre Deak) Signed-off-by: Dave Airlie <[email protected]> From: Tvrtko Ursulin <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/ZJ1WpY+GF9NcsWXp@tursulin-desk
2 parents d011f0c + 5b78263 commit 67ebda8

File tree

7 files changed

+20
-13
lines changed

7 files changed

+20
-13
lines changed

drivers/gpu/drm/i915/display/intel_cx0_phy.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2435,7 +2435,8 @@ static void intel_program_port_clock_ctl(struct intel_encoder *encoder,
24352435

24362436
intel_de_rmw(i915, XELPDP_PORT_CLOCK_CTL(encoder->port),
24372437
XELPDP_LANE1_PHY_CLOCK_SELECT | XELPDP_FORWARD_CLOCK_UNGATE |
2438-
XELPDP_DDI_CLOCK_SELECT_MASK | XELPDP_SSC_ENABLE_PLLB, val);
2438+
XELPDP_DDI_CLOCK_SELECT_MASK | XELPDP_SSC_ENABLE_PLLA |
2439+
XELPDP_SSC_ENABLE_PLLB, val);
24392440
}
24402441

24412442
static u32 intel_cx0_get_powerdown_update(u8 lane_mask)

drivers/gpu/drm/i915/display/intel_display_power.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
#ifndef __INTEL_DISPLAY_POWER_H__
77
#define __INTEL_DISPLAY_POWER_H__
88

9+
#include <linux/mutex.h>
10+
#include <linux/workqueue.h>
11+
912
#include "intel_wakeref.h"
1013

1114
enum aux_ch;
@@ -16,6 +19,7 @@ enum port;
1619
struct drm_i915_private;
1720
struct i915_power_well;
1821
struct intel_encoder;
22+
struct seq_file;
1923

2024
/*
2125
* Keep the pipe, transcoder, port (DDI_LANES,DDI_IO,AUX) domain instances

drivers/gpu/drm/i915/display/intel_display_power_map.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1252,10 +1252,18 @@ I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_a,
12521252
POWER_DOMAIN_INIT);
12531253

12541254
#define XELPD_DC_OFF_PORT_POWER_DOMAINS \
1255+
POWER_DOMAIN_PORT_DDI_LANES_C, \
1256+
POWER_DOMAIN_PORT_DDI_LANES_D, \
1257+
POWER_DOMAIN_PORT_DDI_LANES_E, \
12551258
POWER_DOMAIN_PORT_DDI_LANES_TC1, \
12561259
POWER_DOMAIN_PORT_DDI_LANES_TC2, \
12571260
POWER_DOMAIN_PORT_DDI_LANES_TC3, \
12581261
POWER_DOMAIN_PORT_DDI_LANES_TC4, \
1262+
POWER_DOMAIN_VGA, \
1263+
POWER_DOMAIN_AUDIO_PLAYBACK, \
1264+
POWER_DOMAIN_AUX_IO_C, \
1265+
POWER_DOMAIN_AUX_IO_D, \
1266+
POWER_DOMAIN_AUX_IO_E, \
12591267
POWER_DOMAIN_AUX_C, \
12601268
POWER_DOMAIN_AUX_D, \
12611269
POWER_DOMAIN_AUX_E, \
@@ -1272,14 +1280,6 @@ I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_a,
12721280
XELPD_PW_B_POWER_DOMAINS, \
12731281
XELPD_PW_C_POWER_DOMAINS, \
12741282
XELPD_PW_D_POWER_DOMAINS, \
1275-
POWER_DOMAIN_PORT_DDI_LANES_C, \
1276-
POWER_DOMAIN_PORT_DDI_LANES_D, \
1277-
POWER_DOMAIN_PORT_DDI_LANES_E, \
1278-
POWER_DOMAIN_VGA, \
1279-
POWER_DOMAIN_AUDIO_PLAYBACK, \
1280-
POWER_DOMAIN_AUX_IO_C, \
1281-
POWER_DOMAIN_AUX_IO_D, \
1282-
POWER_DOMAIN_AUX_IO_E, \
12831283
XELPD_DC_OFF_PORT_POWER_DOMAINS
12841284

12851285
I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_2,

drivers/gpu/drm/i915/display/intel_display_power_well.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212

1313
struct drm_i915_private;
1414
struct i915_power_well;
15+
struct i915_power_well_ops;
16+
struct intel_encoder;
1517

1618
#define for_each_power_well(__dev_priv, __power_well) \
1719
for ((__power_well) = (__dev_priv)->display.power.domains.power_wells; \

drivers/gpu/drm/i915/display/intel_hdcp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2358,7 +2358,7 @@ int intel_hdcp_enable(struct intel_atomic_state *state,
23582358
mutex_lock(&dig_port->hdcp_mutex);
23592359
drm_WARN_ON(&i915->drm,
23602360
hdcp->value == DRM_MODE_CONTENT_PROTECTION_ENABLED);
2361-
hdcp->content_type = (u8)conn_state->content_type;
2361+
hdcp->content_type = (u8)conn_state->hdcp_content_type;
23622362

23632363
if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_DP_MST)) {
23642364
hdcp->cpu_transcoder = pipe_config->mst_master_transcoder;

drivers/gpu/drm/i915/display/intel_psr.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -933,9 +933,9 @@ static bool _compute_psr2_wake_times(struct intel_dp *intel_dp,
933933
}
934934

935935
io_wake_lines = intel_usecs_to_scanlines(
936-
&crtc_state->uapi.adjusted_mode, io_wake_time);
936+
&crtc_state->hw.adjusted_mode, io_wake_time);
937937
fast_wake_lines = intel_usecs_to_scanlines(
938-
&crtc_state->uapi.adjusted_mode, fast_wake_time);
938+
&crtc_state->hw.adjusted_mode, fast_wake_time);
939939

940940
if (io_wake_lines > max_wake_lines ||
941941
fast_wake_lines > max_wake_lines)

drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@ static int slpc_set_softlimits(struct intel_guc_slpc *slpc)
606606
if (unlikely(ret))
607607
return ret;
608608
slpc_to_gt(slpc)->defaults.min_freq = slpc->min_freq_softlimit;
609-
} else if (slpc->min_freq_softlimit != slpc->min_freq) {
609+
} else {
610610
return intel_guc_slpc_set_min_freq(slpc,
611611
slpc->min_freq_softlimit);
612612
}

0 commit comments

Comments
 (0)