Skip to content

Commit 6819db9

Browse files
ProjectMutilationmiquelraynal
authored andcommitted
mtd: rawnand: hynix: fixed typo
The function hynix_nand_rr_init() should probably return an error code. Judging by the usage, it seems that the return code is passed up the call stack. Right now, it always returns 0 and the function hynix_nand_cleanup() in hynix_nand_init() has never been called. Found by RASU JSC and Linux Verification Center (linuxtesting.org) Fixes: 626994e ("mtd: nand: hynix: Add read-retry support for 1x nm MLC NANDs") Signed-off-by: Maxim Korotkov <[email protected]> Signed-off-by: Miquel Raynal <[email protected]> Link: https://lore.kernel.org/linux-mtd/[email protected]
1 parent 31e6bb6 commit 6819db9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/mtd/nand/raw/nand_hynix.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ static int hynix_nand_rr_init(struct nand_chip *chip)
401401
if (ret)
402402
pr_warn("failed to initialize read-retry infrastructure");
403403

404-
return 0;
404+
return ret;
405405
}
406406

407407
static void hynix_nand_extract_oobsize(struct nand_chip *chip,

0 commit comments

Comments
 (0)