Skip to content

Commit 688fcd0

Browse files
Wer-Wolfgroeck
authored andcommitted
hwmon: (dell-smm) Move error message to make probing silent
If dell-smm-hwmon loads on unsupported hardware like the Dell XPS 17 9710, an error message is printed. This might confuse users, as drivers are expected to be silent if no supported hardware is found. Reorder the error message so its only printed when the driver is loaded with the "force" option being set. Also reword the error message slightly. Tested on a Dell Inspiron 3505. Signed-off-by: Armin Wolf <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]>
1 parent 4e6104b commit 688fcd0

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/hwmon/dell-smm-hwmon.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1447,9 +1447,10 @@ static int __init i8k_init(void)
14471447
*/
14481448
if (i8k_get_dell_signature(I8K_SMM_GET_DELL_SIG1) &&
14491449
i8k_get_dell_signature(I8K_SMM_GET_DELL_SIG2)) {
1450-
pr_err("unable to get SMM Dell signature\n");
14511450
if (!force)
14521451
return -ENODEV;
1452+
1453+
pr_err("Unable to get Dell SMM signature\n");
14531454
}
14541455

14551456
dell_smm_device = platform_create_bundle(&dell_smm_driver, dell_smm_probe, NULL, 0, NULL,

0 commit comments

Comments
 (0)