Skip to content

Commit 68de0ae

Browse files
zhang-ruirafaeljw
authored andcommitted
thermal: intel: intel_pch: Improve cooling log
The intel_pch_thermal cooling mechanism currently only provides one of the following final conclusions: 1. intel_pch_thermal 0000:00:12.0: CPU-PCH is cool [48C] 2. intel_pch_thermal 0000:00:12.0: CPU-PCH is cool [49C] after 30700 ms delay 3. intel_pch_thermal 0000:00:12.0: CPU-PCH is hot [60C] after 60000 ms delay. S0ix might fail 4. intel_pch_thermal 0000:00:12.0: Wakeup event detected, abort cooling This does not provide sufficient context about what is happening, especially for case 4. Add one line log to indicate when PCH overheats and the cooling delay has started. Signed-off-by: Zhang Rui <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 68f2d1d commit 68de0ae

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/thermal/intel/intel_pch_thermal.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,11 @@ static int intel_pch_thermal_suspend_noirq(struct device *device)
298298
/* Get the PCH current temperature value */
299299
pch_cur_temp = GET_PCH_TEMP(WPT_TEMP_TSR & readw(ptd->hw_base + WPT_TEMP));
300300

301+
if (pch_cur_temp >= pch_thr_temp)
302+
dev_warn(&ptd->pdev->dev,
303+
"CPU-PCH current temp [%dC] higher than the threshold temp [%dC], S0ix might fail. Start cooling...\n",
304+
pch_cur_temp, pch_thr_temp);
305+
301306
/*
302307
* If current PCH temperature is higher than configured PCH threshold
303308
* value, run some delay loop with sleep to let the current temperature

0 commit comments

Comments
 (0)