crypto: engine - Use crypto_request_complete

herbertx · herbertx · commit 6909823d47c1 · 2023-02-13T18:34:49.000+08:00
Use the crypto_request_complete helper instead of calling the
completion function directly.

Signed-off-by: Herbert Xu &lt;herbert@gondor.apana.org.au&gt;
diff --git a/crypto/crypto_engine.c b/crypto/crypto_engine.c
@@ -54,7 +54,7 @@ static void crypto_finalize_request(struct crypto_engine *engine,
 		}
 	}
 	lockdep_assert_in_softirq();
-	req->complete(req, err);
+	crypto_request_complete(req, err);
 
 	kthread_queue_work(engine->kworker, &engine->pump_requests);
 }
@@ -130,7 +130,7 @@ static void crypto_pump_requests(struct crypto_engine *engine,
 		engine->cur_req = async_req;
 
 	if (backlog)
-		backlog->complete(backlog, -EINPROGRESS);
+		crypto_request_complete(backlog, -EINPROGRESS);
 
 	if (engine->busy)
 		was_busy = true;
@@ -214,7 +214,7 @@ static void crypto_pump_requests(struct crypto_engine *engine,
 	}
 
 req_err_2:
-	async_req->complete(async_req, ret);
+	crypto_request_complete(async_req, ret);
 
 retry:
 	/* If retry mechanism is supported, send new requests to engine */

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ static void crypto_finalize_request(struct crypto_engine *engine,`
`54`	`54`	`}`
`55`	`55`	`}`
`56`	`56`	`lockdep_assert_in_softirq();`
`57`		`- req->complete(req, err);`
	`57`	`+ crypto_request_complete(req, err);`
`58`	`58`
`59`	`59`	`kthread_queue_work(engine->kworker, &engine->pump_requests);`
`60`	`60`	`}`
`@@ -130,7 +130,7 @@ static void crypto_pump_requests(struct crypto_engine *engine,`
`130`	`130`	`engine->cur_req = async_req;`
`131`	`131`
`132`	`132`	`if (backlog)`
`133`		`- backlog->complete(backlog, -EINPROGRESS);`
	`133`	`+ crypto_request_complete(backlog, -EINPROGRESS);`
`134`	`134`
`135`	`135`	`if (engine->busy)`
`136`	`136`	`was_busy = true;`
`@@ -214,7 +214,7 @@ static void crypto_pump_requests(struct crypto_engine *engine,`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`req_err_2:`
`217`		`- async_req->complete(async_req, ret);`
	`217`	`+ crypto_request_complete(async_req, ret);`
`218`	`218`
`219`	`219`	`retry:`
`220`	`220`	`/* If retry mechanism is supported, send new requests to engine */`