Skip to content

Commit 690eb7d

Browse files
hadessbentiss
authored andcommitted
HID: logitech: Disable hi-res scrolling on USB
On some Logitech mice, such as the G903, and possibly the G403, the HID events are generated on a different interface to the HID++ one. If we enable hi-res through the HID++ interface, the HID interface wouldn't know anything about it, and handle the events as if they were regular scroll events, making the mouse unusable. Disable hi-res scrolling on those devices until we implement scroll events through HID++. Signed-off-by: Bastien Nocera <[email protected]> Tested-by: Tobias Klausmann <[email protected]> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216885 Fixes: 908d325 ("HID: logitech-hidpp: Detect hi-res scrolling support") Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Benjamin Tissoires <[email protected]>
1 parent ea427a2 commit 690eb7d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/hid/hid-logitech-hidpp.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3978,7 +3978,8 @@ static void hidpp_connect_event(struct hidpp_device *hidpp)
39783978
}
39793979

39803980
hidpp_initialize_battery(hidpp);
3981-
hidpp_initialize_hires_scroll(hidpp);
3981+
if (!hid_is_usb(hidpp->hid_dev))
3982+
hidpp_initialize_hires_scroll(hidpp);
39823983

39833984
/* forward current battery state */
39843985
if (hidpp->capabilities & HIDPP_CAPABILITY_HIDPP10_BATTERY) {

0 commit comments

Comments
 (0)