Skip to content

Commit 69125b4

Browse files
jonhunterpH5
authored andcommitted
reset: tegra-bpmp: Revert Handle errors in BPMP response
Commit c045ceb ("reset: tegra-bpmp: Handle errors in BPMP response") fixed an issue in the Tegra BPMP error handling but has exposed an issue in the Tegra194 HDA driver and now resetting the Tegra194 HDA controller is failing. For now revert the commit c045ceb ("reset: tegra-bpmp: Handle errors in BPMP response") while a fix for the Tegra HDA driver is created. Fixes: c045ceb ("reset: tegra-bpmp: Handle errors in BPMP response") Signed-off-by: Jon Hunter <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Philipp Zabel <[email protected]>
1 parent fa55b7d commit 69125b4

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

drivers/reset/tegra/reset-bpmp.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
2020
struct tegra_bpmp *bpmp = to_tegra_bpmp(rstc);
2121
struct mrq_reset_request request;
2222
struct tegra_bpmp_message msg;
23-
int err;
2423

2524
memset(&request, 0, sizeof(request));
2625
request.cmd = command;
@@ -31,13 +30,7 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
3130
msg.tx.data = &request;
3231
msg.tx.size = sizeof(request);
3332

34-
err = tegra_bpmp_transfer(bpmp, &msg);
35-
if (err)
36-
return err;
37-
if (msg.rx.ret)
38-
return -EINVAL;
39-
40-
return 0;
33+
return tegra_bpmp_transfer(bpmp, &msg);
4134
}
4235

4336
static int tegra_bpmp_reset_module(struct reset_controller_dev *rstc,

0 commit comments

Comments
 (0)