Skip to content

Commit 6929f71

Browse files
committed
atomisp: avoid warning about unused function
The atomisp_mrfld_power() function isn't actually ever called, because the two call-sites have commented out the use because it breaks on some platforms. That results in: drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: warning: ‘atomisp_mrfld_power’ defined but not used [-Wunused-function] 764 | static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) | ^~~~~~~~~~~~~~~~~~~ during the build. Rather than commenting out the use entirely, just disable it semantically instead (using a "0 &&" construct), leaving the call in place from a syntax standpoint, and avoiding the warning. I really don't want my builds to have any warnings that can then hide real issues. Signed-off-by: Linus Torvalds <[email protected]>
1 parent a98f670 commit 6929f71

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

drivers/staging/media/atomisp/pci/atomisp_v4l2.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -824,17 +824,15 @@ static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable)
824824
/* Workaround for pmu_nc_set_power_state not ready in MRFLD */
825825
int atomisp_mrfld_power_down(struct atomisp_device *isp)
826826
{
827-
return 0;
828-
// FIXME: at least with ISP2401, the code below causes the driver to break
829-
// return atomisp_mrfld_power(isp, false);
827+
// FIXME: at least with ISP2401, enabling this code causes the driver to break
828+
return 0 && atomisp_mrfld_power(isp, false);
830829
}
831830

832831
/* Workaround for pmu_nc_set_power_state not ready in MRFLD */
833832
int atomisp_mrfld_power_up(struct atomisp_device *isp)
834833
{
835-
return 0;
836-
// FIXME: at least with ISP2401, the code below causes the driver to break
837-
// return atomisp_mrfld_power(isp, true);
834+
// FIXME: at least with ISP2401, enabling this code causes the driver to break
835+
return 0 && atomisp_mrfld_power(isp, true);
838836
}
839837

840838
int atomisp_runtime_suspend(struct device *dev)

0 commit comments

Comments
 (0)